content/browser/web_contents/web_contents_impl.cc - Issue 722153003: Implement basic mojo Permission service and use it for Geolocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 722153003: Implement basic mojo Permission service and use it for Geolocation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_process_host_impl.cc ('K') | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/BUILD.gn » ('j') | content/common/permission_service.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 3119566b046b6e4467a5bbc03c4b6aa6d8683090..a0d3e514c9a0d0ac0eae3d6533c3347ae9d35f5e 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -35,7 +35,6 @@

#include "content/browser/frame_host/navigator_impl.h"

#include "content/browser/frame_host/render_frame_host_impl.h"

#include "content/browser/frame_host/render_widget_host_view_child_frame.h"

-#include "content/browser/geolocation/geolocation_dispatcher_host.h"

#include "content/browser/geolocation/geolocation_service_context.h"

#include "content/browser/host_zoom_map_impl.h"

#include "content/browser/loader/resource_dispatcher_host_impl.h"

@@ -1189,7 +1188,6 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) {

NOTIFICATION_RENDER_WIDGET_HOST_DESTROYED,

NotificationService::AllBrowserContextsAndSources());

- geolocation_dispatcher_host_.reset(new GeolocationDispatcherHost(this));

midi_dispatcher_host_.reset(new MidiDispatcherHost(this));

screen_orientation_dispatcher_host_.reset(