Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 722153003: Implement basic mojo Permission service and use it for Geolocation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 84a31ba849001026b451f344c400dacf2965db3a..464dbbc043de5938deebfeb360fa71caabc57e2d 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -66,6 +66,8 @@
#include "content/browser/mime_registry_message_filter.h"
#include "content/browser/mojo/mojo_application_host.h"
#include "content/browser/notifications/notification_message_filter.h"
+#include "content/browser/permissions/permission_service_context.h"
+#include "content/browser/permissions/permission_service_impl.h"
#include "content/browser/profiler_message_filter.h"
#include "content/browser/push_messaging/push_messaging_message_filter.h"
#include "content/browser/quota_dispatcher_host.h"
@@ -875,6 +877,12 @@ void RenderProcessHostImpl::CreateMessageFilters() {
void RenderProcessHostImpl::RegisterMojoServices() {
mojo_application_host_->service_registry()->AddService(
base::Bind(&device::BatteryMonitorImpl::Create));
+
+ scoped_ptr<PermissionServiceContext> permission_service_context(
+ new PermissionServiceContext(nullptr));
nasko 2014/11/13 23:57:38 Why is it valid to register a context with null RF
mlamouri (slow - plz ping) 2014/11/14 00:16:33 The service on the RenderProcessHost can't show an
nasko 2014/11/14 00:42:50 I like always having a context and it including th
+ mojo_application_host_->service_registry()->AddService(
+ base::Bind(&PermissionServiceImpl::Create,
+ base::Passed(&permission_service_context)));
}
int RenderProcessHostImpl::GetNextRoutingID() {

Powered by Google App Engine
This is Rietveld 408576698