Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2533)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 722153003: Implement basic mojo Permission service and use it for Geolocation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 6c61bda83347e7ec2ffcbc5e66b4ead0bbd4cfce..4d497d73d551894b75775c0f5d13af71855521b7 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -25,6 +25,8 @@
#include "content/browser/frame_host/render_frame_proxy_host.h"
#include "content/browser/frame_host/render_widget_host_view_child_frame.h"
#include "content/browser/geolocation/geolocation_service_context.h"
+#include "content/browser/permissions/permission_service_context.h"
+#include "content/browser/permissions/permission_service_impl.h"
#include "content/browser/renderer_host/input/input_router.h"
#include "content/browser/renderer_host/input/timeout_monitor.h"
#include "content/browser/renderer_host/render_process_host_impl.h"
@@ -1248,6 +1250,13 @@ void RenderFrameHostImpl::RegisterMojoServices() {
base::Bind(&RenderFrameHostImpl::DidUseGeolocationPermission,
base::Unretained(this))));
}
+
+ if (!permission_service_context_)
+ permission_service_context_.reset(new PermissionServiceContext(this));
blundell 2014/11/14 12:48:08 nit: I think this might as well be a plain object
mlamouri (slow - plz ping) 2014/11/14 13:39:42 The issue is that I use the parameter to access th
+
+ GetServiceRegistry()->AddService<PermissionService>(
+ base::Bind(&PermissionServiceContext::CreateService,
+ base::Unretained(permission_service_context_.get())));
}
void RenderFrameHostImpl::SetState(RenderFrameHostImplState rfh_state) {

Powered by Google App Engine
This is Rietveld 408576698