Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 722143002: Labels with user-select: none should pass events to control element (Closed)

Created:
6 years, 1 month ago by deepak.sa
Modified:
6 years, 1 month ago
Reviewers:
tkent, keishi, esprehn
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Labels with user-select: none should pass events to control element If Label with 'user-select: none' is clicked while there is a selection on the page, label should transfer that click event to control element Test=fast/form/label/selection-disabled-label.html BUG=428092 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185576

Patch Set 1 #

Patch Set 2 : Fixed Layout tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -1 line) Patch
A LayoutTests/fast/forms/label/selection-disabled-label.html View 1 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/label/selection-disabled-label-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/html/HTMLLabelElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
deepak.sa
PTAL?
6 years, 1 month ago (2014-11-13 13:32:50 UTC) #2
deepak.sa
On 2014/11/13 13:32:50, deepak.sa wrote: > PTAL?
6 years, 1 month ago (2014-11-17 04:39:41 UTC) #3
tkent
The code looks ok. The new test is failing on Windows.
6 years, 1 month ago (2014-11-19 01:06:37 UTC) #4
deepak.sa
On 2014/11/19 01:06:37, tkent wrote: > The code looks ok. The new test is failing ...
6 years, 1 month ago (2014-11-19 07:21:42 UTC) #5
tkent
lgtm
6 years, 1 month ago (2014-11-19 07:33:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722143002/20001
6 years, 1 month ago (2014-11-19 07:33:55 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 08:45:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185576

Powered by Google App Engine
This is Rietveld 408576698