Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 722093002: Handle case when XSL stylesheet node is removed during load (Closed)

Created:
6 years, 1 month ago by kochi
Modified:
6 years, 1 month ago
Reviewers:
hayato, tasak
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

Handle case when XSL stylesheet node is removed during load When a XSL stylesheet node is removed from document while its content is being loaded, the current code doesn't handle the case to clear the resource, while when the node is added again the new resource is created again. This causes reference count (StyleEngine::m_pendingStyleSheets) leakage. BUG=427249 TEST=minimized clusterfuzz test Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185504

Patch Set 1 #

Patch Set 2 : speculative fix for layout test #

Patch Set 3 : refine layout test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M LayoutTests/fast/dom/StyleSheet/detached-style-pi-2.xhtml View 1 2 2 chunks +19 lines, -4 lines 0 comments Download
M Source/core/dom/ProcessingInstruction.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
kochi
Hi Takashi, As we analyzed together, a case when XSL stylesheet loading is interrupted by ...
6 years, 1 month ago (2014-11-13 06:35:14 UTC) #2
tasak
lgtm
6 years, 1 month ago (2014-11-13 06:58:16 UTC) #3
kochi
On 2014/11/13 06:58:16, tasak wrote: > lgtm Thanks. Hayato-san, Could you review as OWNERS?
6 years, 1 month ago (2014-11-13 07:39:31 UTC) #4
hayato
LGTM
6 years, 1 month ago (2014-11-14 09:58:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722093002/1
6 years, 1 month ago (2014-11-14 09:58:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/30862)
6 years, 1 month ago (2014-11-14 11:23:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722093002/1
6 years, 1 month ago (2014-11-14 14:56:23 UTC) #11
kochi
On 2014/11/14 14:56:23, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 1 month ago (2014-11-14 14:57:47 UTC) #13
kochi
Updated the layout test. Takashi, could you take another look?
6 years, 1 month ago (2014-11-17 05:52:31 UTC) #14
tasak
lgtm
6 years, 1 month ago (2014-11-18 06:31:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722093002/40001
6 years, 1 month ago (2014-11-18 06:44:01 UTC) #17
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 07:33:46 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185504

Powered by Google App Engine
This is Rietveld 408576698