Issue 722043005: Revert of allow pictures to have a full bounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 722043005: Revert of allow pictures to have a full bounds (Closed)

Created:
6 years, 1 month ago by reed1

Modified:
6 years, 1 month ago

Reviewers:
mtklein, f(malita), fmalita_google_do_not_use, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of allow pictures to have a full bounds (patchset #3 id:40001 of https://codereview.chromium.org/736583004/) Reason for revert: needed to update legacy width() helpers Original issue's description: > allow pictures to have a full bounds > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/7e76bff26e7c74902841ca4f607eb0b24a833a4a TBR=fmalita@google.com,mtklein@google.com,robertphillips@google.com,fmalita@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/7c4cdd2c5b7b6c71fa0e7612594f7885f2dbf264

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -105 lines)			Patch
M	include/core/SkBBHFactory.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	include/core/SkCanvas.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkDevice.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	include/core/SkPicture.h	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	include/core/SkPictureRecorder.h	View	2 chunks	+3 lines, -8 lines	0 comments	Download
M	samplecode/SampleArc.cpp	View	2 chunks	+0 lines, -23 lines	0 comments	Download
M	src/core/SkBBHFactory.cpp	View	1 chunk	+4 lines, -9 lines	0 comments	Download
M	src/core/SkCanvas.cpp	View	3 chunks	+7 lines, -12 lines	0 comments	Download
M	src/core/SkCanvasDrawable.cpp	View	2 chunks	+2 lines, -20 lines	0 comments	Download
M	src/core/SkPicture.cpp	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/core/SkPictureRecorder.cpp	View	3 chunks	+10 lines, -7 lines	0 comments	Download
M	src/core/SkRecorder.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/core/SkRecorder.cpp	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	tests/PictureTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722043005/1

6 years, 1 month ago (2014-11-19 15:17:07 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-11-19 15:17:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7c4cdd2c5b7b6c71fa0e7612594f7885f2dbf264