Introduce RenderProcessHostObserver, use it in its first client.

content/public/browser/render_process_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_
 #define CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_
 
 #include "base/basictypes.h"
 #include "base/id_map.h"
 #include "base/process/kill.h"
 #include "base/process/process_handle.h"
 #include "base/supports_user_data.h"
 #include "content/common/content_export.h"
 #include "ipc/ipc_channel_proxy.h"
 #include "ipc/ipc_sender.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/surface/transport_dib.h"
 
 class GURL;
 struct ViewMsg_SwapOut_Params;
 
 namespace base {
 class TimeDelta;
 }
 
 namespace content {
 class BrowserContext;
 class BrowserMessageFilter;
+class RenderProcessHostObserver;
 class RenderWidgetHost;
 class StoragePartition;
 
 typedef base::Thread* (*RendererMainThreadFactoryFunction)(
     const std::string& id);
 
 // Interface that represents the browser side of the browser <-> renderer
 // communication channel. There will generally be one RenderProcessHost per
 // renderer process.
 class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,
                                          public IPC::Listener,
                                          public base::SupportsUserData {
  public:
   typedef IDMap<RenderProcessHost>::iterator iterator;
 
   // Details for RENDERER_PROCESS_CLOSED notifications.
   struct RendererClosedDetails {
     RendererClosedDetails(base::ProcessHandle handle,
                           base::TerminationStatus status,
                           int exit_code) {
       this->handle = handle;
       this->status = status;
       this->exit_code = exit_code;
     }
     base::ProcessHandle handle;
     base::TerminationStatus status;
     int exit_code;
   };
 
+  // General functions ---------------------------------------------------------
+
   virtual ~RenderProcessHost() {}
 
   // Initialize the new renderer process, returning true on success. This must
   // be called once before the object can be used, but can be called after
   // that with no effect. Therefore, if the caller isn't sure about whether
   // the process has been created, it should just call Init().
   virtual bool Init() = 0;
 
   // Gets the next available routing id.
   virtual int GetNextRoutingID() = 0;
 
   // These methods add or remove listener for a specific message routing ID.
   // Used for refcounting, each holder of this object must AddRoute and
   // RemoveRoute. This object should be allocated on the heap; when no
   // listeners own it any more, it will delete itself.
   virtual void AddRoute(int32 routing_id, IPC::Listener* listener) = 0;
   virtual void RemoveRoute(int32 routing_id) = 0;
 
+  // Add and remove observers for lifecycle events. The order in which
+  // notifications are sent to observers is undefined. Observers must be sure to
+  // remove the observer before they go away.
+  virtual void AddObserver(RenderProcessHostObserver* observer) = 0;
+  virtual void RemoveObserver(RenderProcessHostObserver* observer) = 0;
+
   // Called to wait for the next UpdateRect message for the specified render
   // widget.  Returns true if successful, and the msg out-param will contain a
   // copy of the received UpdateRect message.
   virtual bool WaitForBackingStoreMsg(int render_widget_id,
                                       const base::TimeDelta& max_delay,
                                       IPC::Message* msg) = 0;
 
   // Called when a received message cannot be decoded.
   virtual void ReceivedBadMessage() = 0;
 
@@ skipping 123 matching lines @@
   // to a RenderProcess which is instantiated in the same process
   // with the Browser.  All IPC between the Browser and the
   // Renderer is the same, it's just not crossing a process boundary.
 
   static bool run_renderer_in_process();
 
   // This also calls out to ContentBrowserClient::GetApplicationLocale and
   // modifies the current process' command line.
   static void SetRunRendererInProcess(bool value);
 
+  // This forces a renderer that is running "in process" to shut down.
+  static void ShutDownInProcessRenderer();

[jam, 2013/11/18 19:16:20]

nit: since this is only called inside content, put this on
RenderProcessHostImpl. then you can get rid of the "friend" in
render_process_host_impl.h

[Avi (use Gerrit), 2013/11/18 19:22:21]

Right. I was thinking BrowserMainLoop was in chrome/.

+
   // Allows iteration over all the RenderProcessHosts in the browser. Note
   // that each host may not be active, and therefore may have NULL channels.
   static iterator AllHostsIterator();
 
   // Returns the RenderProcessHost given its ID.  Returns NULL if the ID does
   // not correspond to a live RenderProcessHost.
   static RenderProcessHost* FromID(int render_process_id);
 
   // Returns whether the process-per-site model is in use (globally or just for
   // the current site), in which case we should ensure there is only one
@@ skipping 26 matching lines @@
   // module.
   static size_t GetMaxRendererProcessCount();
 
   static void RegisterRendererMainThreadFactory(
       RendererMainThreadFactoryFunction create);
 };
 
 }  // namespace content.
 
 #endif  // CONTENT_PUBLIC_BROWSER_RENDER_PROCESS_HOST_H_