Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 7219002: Chromoting's ContinueWindow implementation for Windows. (Closed)

Created:
9 years, 6 months ago by garykac
Modified:
9 years, 6 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Chromoting's ContinueWindow implementation for Windows. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90124

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 4

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -41 lines) Patch
M remoting/host/continue_window_win.cc View 1 2 3 4 1 chunk +100 lines, -6 lines 0 comments Download
M remoting/host/disconnect_window_win.cc View 1 2 3 4 5 chunks +29 lines, -29 lines 0 comments Download
M remoting/host/plugin/host_plugin.rc View 1 2 3 2 chunks +20 lines, -2 lines 0 comments Download
M remoting/host/plugin/host_plugin_resource.h View 1 2 3 1 chunk +7 lines, -4 lines 0 comments Download
M remoting/remoting.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
garykac
9 years, 6 months ago (2011-06-21 01:11:51 UTC) #1
garykac
9 years, 6 months ago (2011-06-21 01:11:53 UTC) #2
Jamie
http://codereview.chromium.org/7219002/diff/5003/remoting/host/continue_window_win.cc File remoting/host/continue_window_win.cc (right): http://codereview.chromium.org/7219002/diff/5003/remoting/host/continue_window_win.cc#newcode49 remoting/host/continue_window_win.cc:49: DWORD key_; What is this designed to protect against? ...
9 years, 6 months ago (2011-06-21 23:09:45 UTC) #3
garykac
http://codereview.chromium.org/7219002/diff/5003/remoting/host/continue_window_win.cc File remoting/host/continue_window_win.cc (right): http://codereview.chromium.org/7219002/diff/5003/remoting/host/continue_window_win.cc#newcode49 remoting/host/continue_window_win.cc:49: DWORD key_; On 2011/06/21 23:09:45, Jamie wrote: > What ...
9 years, 6 months ago (2011-06-22 00:36:59 UTC) #4
Jamie
9 years, 6 months ago (2011-06-22 00:39:08 UTC) #5
LGTM.

Powered by Google App Engine
This is Rietveld 408576698