Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 721883002: Add flag to beginRecording to request saveLayer information (Closed)

Created:
6 years, 1 month ago by robertphillips
Modified:
6 years, 1 month ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add flag to beginRecording to request saveLayer information The saveLayer acceleration data is required for layer hoisting and shouldn't impact recording time. This patch makes Chromium request the data be collected for those picture likely to be GPU rasterized. BUG=383085 Committed: https://crrev.com/5980d991c03cf7d60bc89f7046c87d984988c3cb Cr-Commit-Position: refs/heads/master@{#304602}

Patch Set 1 #

Patch Set 2 : Remove unneeded SkRTreeFactory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M cc/resources/gpu_raster_worker_pool.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M cc/resources/picture.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
robertphillips
6 years, 1 month ago (2014-11-17 20:19:15 UTC) #3
enne (OOO)
lgtm Can you please format your patch description to wrap at 72 columns?
6 years, 1 month ago (2014-11-17 20:47:19 UTC) #4
robertphillips
On 2014/11/17 20:47:19, enne wrote: > lgtm > > Can you please format your patch ...
6 years, 1 month ago (2014-11-18 13:49:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721883002/40001
6 years, 1 month ago (2014-11-18 13:52:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 1 month ago (2014-11-18 14:48:54 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 14:49:48 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5980d991c03cf7d60bc89f7046c87d984988c3cb
Cr-Commit-Position: refs/heads/master@{#304602}

Powered by Google App Engine
This is Rietveld 408576698