Disable RTHB on Mac when TOOLKIT_VIEWS isn't defined

ui/gfx/render_text.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/render_text.h"
 
 #include <algorithm>
 #include <climits>
 
 #include "base/command_line.h"
@@ skipping 380 matching lines @@
   paint->setAutohinted(params.autohinter);
   paint->setHinting(FontRenderParamsHintingToSkPaintHinting(params.hinting));
 }
 
 }  // namespace internal
 
 RenderText::~RenderText() {
 }
 
 RenderText* RenderText::CreateInstance() {
+#if defined(OS_MACOSX) && !defined(TOOLKIT_VIEWS)
+  return CreateNativeInstance();

[msw, 2014/11/12 18:55:21]

Allow HarfBuzz with switches::kEnableHarfBuzzRenderText for testing.

[ckocagil, 2014/11/12 19:23:01]

Done.

+#else
   return CommandLine::ForCurrentProcess()->HasSwitch(

[msw, 2014/11/12 18:55:21]

optional nit: cache the command line value in a static local bool.
  static const bool use_harfbuzz = !CommandLine::ForCurrentProcess()->
      HasSwitch(switches::kDisableHarfBuzzRenderText);
  return use_harfbuzz ? new RenderTextHarfBuzz() : CreateNativeInstance();

[ckocagil, 2014/11/12 19:23:01]

Done.

       switches::kDisableHarfBuzzRenderText) ? CreateNativeInstance() :
       new RenderTextHarfBuzz;
+#endif
 }
 
 void RenderText::SetText(const base::string16& text) {
   DCHECK(!composition_range_.IsValid());
   if (text_ == text)
     return;
   text_ = text;
 
   // Adjust ranged styles and colors to accommodate a new text length.
   // Clear style ranges as they might break new text graphemes and apply
@@ skipping 984 matching lines @@
   SetDisplayOffset(display_offset_.x() + delta_x);
 }
 
 void RenderText::DrawSelection(Canvas* canvas) {
   const std::vector<Rect> sel = GetSubstringBounds(selection());
   for (std::vector<Rect>::const_iterator i = sel.begin(); i < sel.end(); ++i)
     canvas->FillRect(*i, selection_background_focused_color_);
 }
 
 }  // namespace gfx