Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 721823002: ozone: Interpret absolute events for graphics tablets (Closed)

Created:
6 years, 1 month ago by robert.bradford
Modified:
6 years, 1 month ago
Reviewers:
dnicoara, spang
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@o
Project:
chromium
Visibility:
Public.

Description

ozone: Interpret absolute events for graphics tablets This change adds a TabletEventConverterEvdev that handles absolute evdev events generated by graphics tablets (like a Wacom.) It maps absolute co-ordinate from the input range into the screen that currently has the cursor, thus providing multiple desktop support. In order to handle the absolute position relative to the current screen a new API call (GetCursorDisplayBounds) is added to EvdevCursorDelegate and its implementation in DriCursor to provide the bounds of the curren display. MoveCursorTo is also overloaded to add a version that reuses the existing cursor window. TEST=On link_freon with a Wacom graphics tablet behaves as per X11, stylus mapped to active screen where cursor is present, tap emulates left mouse button, stylus button emulates right mouse click. All other input devices (keyboard, touchpad, touchscreen and mouse) all function as expected. New tests added to event_unittests. BUG=432547 Committed: https://crrev.com/d5e789eaa18748652ffb4211a73485fb59d2d886 Cr-Commit-Position: refs/heads/master@{#305013}

Patch Set 1 #

Patch Set 2 : Add unit test #

Patch Set 3 : Rebased #

Patch Set 4 : Fix signedness issue in test #

Patch Set 5 : Add a GetCursorDisplayBounds() method #

Patch Set 6 : Add missing initialisers for class members on TabletEventConverterEvdev #

Unified diffs Side-by-side diffs Delta from patch set Stats (+673 lines, -27 lines) Patch
M ui/events/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/events.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/ozone/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/cursor_delegate_evdev.h View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
A + ui/events/ozone/evdev/tablet_event_converter_evdev.h View 1 2 3 4 2 chunks +30 lines, -27 lines 0 comments Download
A ui/events/ozone/evdev/tablet_event_converter_evdev.cc View 1 2 3 4 5 1 chunk +167 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc View 1 2 3 4 1 chunk +436 lines, -0 lines 0 comments Download
M ui/events/ozone/events_ozone.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri_cursor.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri_cursor.cc View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
robert.bradford
6 years, 1 month ago (2014-11-12 18:22:13 UTC) #1
robert.bradford
Hi PTAL at this patch to add support for Wacom tablets to ozone. I know ...
6 years, 1 month ago (2014-11-18 19:28:23 UTC) #3
spang
On 2014/11/18 19:28:23, robert.bradford wrote: > Hi PTAL at this patch to add support for ...
6 years, 1 month ago (2014-11-18 20:24:37 UTC) #4
spang
On 2014/11/18 20:24:37, spang wrote: > On 2014/11/18 19:28:23, robert.bradford wrote: > > Hi PTAL ...
6 years, 1 month ago (2014-11-18 20:26:14 UTC) #5
robert.bradford
Hi Michael, thanks for the speedy feedback. Here is an updated version that adds that ...
6 years, 1 month ago (2014-11-19 19:19:05 UTC) #6
spang
lgtm
6 years, 1 month ago (2014-11-19 19:27:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721823002/100001
6 years, 1 month ago (2014-11-20 13:32:49 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:100001)
6 years, 1 month ago (2014-11-20 14:47:02 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 14:47:46 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/d5e789eaa18748652ffb4211a73485fb59d2d886
Cr-Commit-Position: refs/heads/master@{#305013}

Powered by Google App Engine
This is Rietveld 408576698