Issue 721793002: Revert "Only allow background tabs if the underlying input event allows it"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 721793002: Revert "Only allow background tabs if the underlying input event allows it" (Closed)

Created:
6 years, 1 month ago by Stephen White

Modified:
6 years, 1 month ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert "Only allow background tabs if the underlying input event allows it" This reverts commit c67fa612fedd3cf79f999ad61f2022dec85ff032, aka r185205. Speculative revert to green up browser_tests: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=PrerenderBrowserTest.PrerenderClickNewBackgroundTab TBR=jochen@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185220

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -37 lines)			Patch
	M	Source/web/FrameLoaderClientImpl.cpp	View		1 chunk	+0 lines, -37 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Stephen White

Committed patchset #1 (id:1) manually as 185220 (presubmit successful).

6 years, 1 month ago (2014-11-12 17:07:46 UTC) #1

jochen (gone - plz use gerrit)

6 years, 1 month ago (2014-11-13 19:40:53 UTC) #2

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/720283002/ by jochen@chromium.org.

The reason for reverting is: Removed failing browser test.

Expand Messages | Collapse Messages