chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc - Issue 721783003: Remove implicit conversions from scoped_refptr to T* in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc

Issue 721783003: Remove implicit conversions from scoped_refptr to T* in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc

diff --git a/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc b/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc

index 3f09ca466e781151fe7b430233caa0f7076fea5e..9d60a6354b8fc4edc0bc47ac6184a6e7b96f2967 100644

--- a/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc

+++ b/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc

@@ -162,7 +162,7 @@ TEST_F(OverrideSettingsTest, ParseBrokenManifest) {

Extension::NO_FLAGS,

&error);

#if defined(OS_WIN)

- EXPECT_FALSE(extension);

+ EXPECT_FALSE(extension.get());

EXPECT_EQ(

extensions::ErrorUtils::FormatErrorMessage(

extensions::manifest_errors::kInvalidEmptyDictionary,

« no previous file with comments | « no previous file | chrome/service/cloud_print/print_system_win.cc » ('j') | chrome/service/cloud_print/print_system_win.cc » ('J')