Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 721773005: [Slimming Paint] Add *FilterDisplayItem type for slimming paint (Closed)

Created:
6 years, 1 month ago by chrishtr
Modified:
6 years, 1 month ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, slimming-paint-reviews_chromium.org
Project:
blink
Visibility:
Public.

Description

[Slimming Paint] Add *FilterDisplayItem types for slimming paint. (Have not yet checked how many tests pass with slimming paint on, that will be next.) BUG=423071 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185401

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -12 lines) Patch
M Source/core/paint/FilterPainter.h View 1 3 chunks +27 lines, -0 lines 0 comments Download
M Source/core/paint/FilterPainter.cpp View 1 2 2 chunks +51 lines, -9 lines 0 comments Download
M Source/core/paint/ViewDisplayList.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/paint/ViewDisplayList.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/paint/ViewDisplayListTest.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
chrishtr
6 years, 1 month ago (2014-11-14 23:25:30 UTC) #2
pdr.
https://codereview.chromium.org/721773005/diff/20001/Source/core/paint/FilterPainter.cpp File Source/core/paint/FilterPainter.cpp (right): https://codereview.chromium.org/721773005/diff/20001/Source/core/paint/FilterPainter.cpp#newcode58 Source/core/paint/FilterPainter.cpp:58: fprintf(stderr, "FilterPainter\n"); printfs! https://codereview.chromium.org/721773005/diff/20001/Source/core/paint/FilterPainter.cpp#newcode110 Source/core/paint/FilterPainter.cpp:110: endFilterDisplayItem->replay(m_context); Can we avoid ...
6 years, 1 month ago (2014-11-14 23:33:43 UTC) #3
chrishtr
https://codereview.chromium.org/721773005/diff/20001/Source/core/paint/FilterPainter.cpp File Source/core/paint/FilterPainter.cpp (right): https://codereview.chromium.org/721773005/diff/20001/Source/core/paint/FilterPainter.cpp#newcode58 Source/core/paint/FilterPainter.cpp:58: fprintf(stderr, "FilterPainter\n"); On 2014/11/14 23:33:43, pdr wrote: > printfs! ...
6 years, 1 month ago (2014-11-14 23:36:31 UTC) #4
pdr.
Code LGTM
6 years, 1 month ago (2014-11-14 23:44:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721773005/40001
6 years, 1 month ago (2014-11-14 23:50:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/30998)
6 years, 1 month ago (2014-11-15 01:03:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721773005/40001
6 years, 1 month ago (2014-11-15 01:03:47 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-15 01:39:16 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 185401

Powered by Google App Engine
This is Rietveld 408576698