Build animated font properties through FontBuilder.

Build animated font properties through FontBuilder.

Font mutations during style resolution should happen through the FontBuilder
of the StyleResolverState. Otherwise, the elaborate zooming and min-max
logic in FontSize via FontBuilder is not applied.

It is also good etiquette by AnimatedStyleBuilder to *not* secretly update
the Font without notice, because it makes the 'fontDirty' flag wrong, in
some cases. (Although the worst-case scenario is just an extra Font update).

FontBuilder::setSize used to accept a CSSValue*, and I would assume that's
why RenderStyle::setFontSize was created in the first place. It's easy to
cleanly set a new size on the builder now, though.

R=alancutter@chromium.org
BUG=227545
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185449

[dstockwell, 2014-11-12 22:41:11]

https://codereview.chromium.org/721773002/diff/20001/LayoutTests/animations/i...
File LayoutTests/animations/interpolation/font-size-zoom-interpolation.html
(left):

https://codereview.chromium.org/721773002/diff/20001/LayoutTests/animations/i...
LayoutTests/animations/interpolation/font-size-zoom-interpolation.html:26: from:
'4px',
I don't understand the changes to this test. It's hard to see what impact the
code changes have given the changes to this test.

[andersr, 2014-11-13 00:30:19]

https://codereview.chromium.org/721773002/diff/20001/LayoutTests/animations/i...
File LayoutTests/animations/interpolation/font-size-zoom-interpolation.html
(left):

https://codereview.chromium.org/721773002/diff/20001/LayoutTests/animations/i...
LayoutTests/animations/interpolation/font-size-zoom-interpolation.html:26: from:
'4px',
On 2014/11/12 22:41:11, dstockwell wrote:
> I don't understand the changes to this test. It's hard to see what impact the
> code changes have given the changes to this test.

You're seeing creative diffing between a new test and a similar old (unmodified)
test. I re-uploaded the same patch with --no-find-copies.

[dstockwell, 2014-11-13 00:42:47]

On 2014/11/13 at 00:30:19, andersr wrote:
>
https://codereview.chromium.org/721773002/diff/20001/LayoutTests/animations/i...
> File LayoutTests/animations/interpolation/font-size-zoom-interpolation.html
(left):
> 
>
https://codereview.chromium.org/721773002/diff/20001/LayoutTests/animations/i...
> LayoutTests/animations/interpolation/font-size-zoom-interpolation.html:26:
from: '4px',
> On 2014/11/12 22:41:11, dstockwell wrote:
> > I don't understand the changes to this test. It's hard to see what impact
the
> > code changes have given the changes to this test.
> 
> You're seeing creative diffing between a new test and a similar old
(unmodified) test. I re-uploaded the same patch with --no-find-copies.

Sorry! Clearly wasn't paying attention.

[alancutter (OOO until 2018), 2014-11-15 09:15:27]

lgtm

https://codereview.chromium.org/721773002/diff/40001/LayoutTests/animations/i...
File LayoutTests/animations/interpolation/font-size-zoom-interpolation.html
(right):

https://codereview.chromium.org/721773002/diff/40001/LayoutTests/animations/i...
LayoutTests/animations/interpolation/font-size-zoom-interpolation.html:27: {at:
-2, is: '0px'},
We should keep the comment here stating that this interpolated value has been
clamped at 0.

[andersr, 2014-11-17 10:21:58]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-11-17 10:22:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/721773002/60001

[commit-bot: I haz the power, 2014-11-17 10:26:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-17 10:26:03]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[rune, 2014-11-17 11:22:50]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2014-11-17 11:22:51]

lgtm with nits

Description: should happen _through_ the FontBuilder

https://codereview.chromium.org/721773002/diff/60001/LayoutTests/animations/i...
File LayoutTests/animations/interpolation/font-size-zoom-interpolation.html
(right):

https://codereview.chromium.org/721773002/diff/60001/LayoutTests/animations/i...
LayoutTests/animations/interpolation/font-size-zoom-interpolation.html:14:
<body>
Body should be left out.

[andersr, 2014-11-17 12:15:21]

On 2014/11/17 11:22:51, rune wrote:
> lgtm with nits
> 
> Description: should happen _through_ the FontBuilder

Done. Thanks!

[andersr, 2014-11-17 12:15:28]

https://codereview.chromium.org/721773002/diff/60001/LayoutTests/animations/i...
File LayoutTests/animations/interpolation/font-size-zoom-interpolation.html
(right):

https://codereview.chromium.org/721773002/diff/60001/LayoutTests/animations/i...
LayoutTests/animations/interpolation/font-size-zoom-interpolation.html:14:
<body>
On 2014/11/17 11:22:50, rune wrote:
> Body should be left out.

Done.

[andersr, 2014-11-17 12:15:32]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-11-17 12:16:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/721773002/80001

[commit-bot: I haz the power, 2014-11-17 14:21:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-17 14:21:45]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/36826)

[andersr, 2014-11-17 15:11:32]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-11-17 15:12:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/721773002/80001

[commit-bot: I haz the power, 2014-11-17 15:54:34]

Committed patchset #5 (id:80001) as 185449