Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2203)

Unified Diff: Source/devtools/front_end/ui/FlameChart.js

Issue 721703002: DevTools: instant events should not overlap on Timeline flame chart when zooming in (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineFlameChart.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ui/FlameChart.js
diff --git a/Source/devtools/front_end/ui/FlameChart.js b/Source/devtools/front_end/ui/FlameChart.js
index 884506cecfe268a106bf25964fc1fec592769062..8c539eeb72945028ec98b1a806ce756b5530ba96 100644
--- a/Source/devtools/front_end/ui/FlameChart.js
+++ b/Source/devtools/front_end/ui/FlameChart.js
@@ -93,7 +93,7 @@ WebInspector.FlameChart = function(dataProvider, flameChartDelegate, isTopDown)
this._timeWindowRight = Infinity;
this._barHeight = dataProvider.barHeight();
this._barHeightDelta = this._isTopDown ? -this._barHeight : this._barHeight;
- this._minWidth = 1;
+ this._minWidth = 2;
this._paddingLeft = this._dataProvider.paddingLeft();
this._markerPadding = 2;
this._markerRadius = this._barHeight / 2 - this._markerPadding;
@@ -908,9 +908,9 @@ WebInspector.FlameChart.prototype = {
var entryStartTimes = timelineData.entryStartTimes;
var entryLevels = timelineData.entryLevels;
- var titleIndices = new Uint32Array(timelineData.entryTotalTimes);
+ var titleIndices = new Uint32Array(entryTotalTimes.length);
var nextTitleIndex = 0;
- var markerIndices = new Uint32Array(timelineData.entryTotalTimes);
+ var markerIndices = new Uint32Array(entryTotalTimes.length);
var nextMarkerIndex = 0;
var textPadding = this._dataProvider.textPadding();
this._minTextWidth = 2 * textPadding + this._measureWidth(context, "\u2026");
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineFlameChart.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698