Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1663)

Unified Diff: Source/devtools/front_end/components/FlameChart.js

Issue 721703002: DevTools: instant events should not overlap on Timeline flame chart when zooming in (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/FlameChart.js
diff --git a/Source/devtools/front_end/components/FlameChart.js b/Source/devtools/front_end/components/FlameChart.js
index 15cd67d576ee0de431f622e800e0ec4aa246bd05..a9fc5e2989cf436e12c5109ca1fa33651f08ad41 100644
--- a/Source/devtools/front_end/components/FlameChart.js
+++ b/Source/devtools/front_end/components/FlameChart.js
@@ -93,7 +93,7 @@ WebInspector.FlameChart = function(dataProvider, flameChartDelegate, isTopDown)
this._timeWindowRight = Infinity;
this._barHeight = dataProvider.barHeight();
this._barHeightDelta = this._isTopDown ? -this._barHeight : this._barHeight;
- this._minWidth = 1;
+ this._minWidth = 2;
this._paddingLeft = this._dataProvider.paddingLeft();
this._markerPadding = 2;
this._markerRadius = this._barHeight / 2 - this._markerPadding;
@@ -908,9 +908,9 @@ WebInspector.FlameChart.prototype = {
var entryStartTimes = timelineData.entryStartTimes;
var entryLevels = timelineData.entryLevels;
- var titleIndices = new Uint32Array(timelineData.entryTotalTimes);
+ var titleIndices = new Uint32Array(entryTotalTimes);
alph 2014/11/12 13:42:57 could you please add .length
yurys 2014/11/12 13:46:50 Done.
var nextTitleIndex = 0;
- var markerIndices = new Uint32Array(timelineData.entryTotalTimes);
+ var markerIndices = new Uint32Array(entryTotalTimes);
alph 2014/11/12 13:42:57 ditto
yurys 2014/11/12 13:46:50 Done.
var nextMarkerIndex = 0;
var textPadding = this._dataProvider.textPadding();
this._minTextWidth = 2 * textPadding + this._measureWidth(context, "\u2026");

Powered by Google App Engine
This is Rietveld 408576698