Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Issue 721603002: If an element A has a parent element, then A's assigned context menu is the assigned context menu o… (Closed)

Created:
6 years, 1 month ago by pals
Modified:
6 years, 1 month ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

If an element A has a parent element, then A's assigned context menu is the assigned context menu of its parent element. Otherwise, A's assigned context menu is null. Specification: https://html.spec.whatwg.org/multipage/forms.html#assigned-context-menu "Each element has an assigned context menu, which can be null. If an element A has a contextmenu attribute, and there is an element with the ID given by A's contextmenu attribute's value in A's home subtree, and the first such element in tree order is a menu element whose type attribute is in the popup menu state, then A's assigned context menu is that element. Otherwise, if A has a parent element, then A's assigned context menu is the assigned context menu of its parent element. Otherwise, A's assigned context menu is null." BUG=424494 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185198

Patch Set 1 #

Total comments: 8

Patch Set 2 : assignedContextMenu #

Total comments: 4

Patch Set 3 : Fixed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2 lines) Patch
M LayoutTests/fast/dom/HTMLElement/contextmenu.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/HTMLElement/contextmenu-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu.html View 1 3 chunks +21 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/page/ContextMenuController.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
pals
Please review.
6 years, 1 month ago (2014-11-12 07:03:33 UTC) #2
tkent
https://codereview.chromium.org/721603002/diff/1/LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu.html File LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu.html (left): https://codereview.chromium.org/721603002/diff/1/LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu.html#oldcode11 LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu.html:11: <menuitem label="Item1"></menuitem> Please don't change lines unrelated to the ...
6 years, 1 month ago (2014-11-12 07:17:21 UTC) #3
pals
Added a new function assignedContextMenu(). PTAL. https://codereview.chromium.org/721603002/diff/1/LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu.html File LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu.html (left): https://codereview.chromium.org/721603002/diff/1/LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu.html#oldcode11 LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu.html:11: <menuitem label="Item1"></menuitem> On ...
6 years, 1 month ago (2014-11-12 09:30:05 UTC) #4
tkent
Please put a short summary of the change at the beginning of the CL description. ...
6 years, 1 month ago (2014-11-12 09:37:19 UTC) #5
pals
Fixed the comments and updated the description. Please review. https://codereview.chromium.org/721603002/diff/20001/Source/core/html/HTMLElement.cpp File Source/core/html/HTMLElement.cpp (right): https://codereview.chromium.org/721603002/diff/20001/Source/core/html/HTMLElement.cpp#newcode940 Source/core/html/HTMLElement.cpp:940: ...
6 years, 1 month ago (2014-11-12 09:43:59 UTC) #6
tkent
lgtm
6 years, 1 month ago (2014-11-12 10:04:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721603002/40001
6 years, 1 month ago (2014-11-12 10:04:58 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 11:22:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 185198

Powered by Google App Engine
This is Rietveld 408576698