Issue 7216027: typesafe call-on-main-thread interface. no cast to/from void* required.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7216027: typesafe call-on-main-thread interface. no cast to/from void* required. (Closed)

Created:
9 years, 6 months ago by bsy

Modified:
9 years, 6 months ago

Reviewers:
noelallen_use_chromium

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

Description

typesafe call-on-main-thread interface. no cast to/from void* required. Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=5766

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -39 lines)			Patch
M	src/trusted/plugin/service_runtime.h	View		2 chunks	+0 lines, -26 lines	0 comments	Download
M	src/trusted/plugin/service_runtime.cc	View	1 2	2 chunks	+9 lines, -13 lines	0 comments	Download
A	src/trusted/weak_ref/call_on_main_thread.h	View	1 2	1 chunk	+102 lines, -0 lines	0 comments	Download
M	src/trusted/weak_ref/weak_ref.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/trusted/weak_ref/weak_ref.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bsy

9 years, 6 months ago (2011-06-23 19:50:04 UTC) #3

thx.  r5766.

On Wed, Jun 22, 2011 at 6:02 PM, <noelallen@google.com> wrote:

> LGTM.
>
>
>
http://codereview.chromium.**org/7216027/<http://codereview.chromium.org/7216...
>



-- 
bennet s yee
i usually don't capitalize due to mild tendonitis

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

Expand Messages | Collapse Messages