Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 7216012: Test cases for the cloud policy subsystem (Closed)

Created:
9 years, 6 months ago by gfeher
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Test cases for the cloud policy subsystem BUG=chromium-os:16637 TEST=compiles and passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90211

Patch Set 1 #

Patch Set 2 : " #

Total comments: 4

Patch Set 3 : address commens #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -81 lines) Patch
M chrome/browser/policy/cloud_policy_subsystem_unittest.cc View 1 2 5 chunks +222 lines, -81 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gfeher
Some of you please review this. It includes a lot of gtest and gmock fun!
9 years, 6 months ago (2011-06-21 15:26:52 UTC) #1
Joao da Silva
LGTM, but please have a stamp from another reviewer too! http://codereview.chromium.org/7216012/diff/4/chrome/browser/policy/cloud_policy_subsystem_unittest.cc File chrome/browser/policy/cloud_policy_subsystem_unittest.cc (right): http://codereview.chromium.org/7216012/diff/4/chrome/browser/policy/cloud_policy_subsystem_unittest.cc#newcode197 ...
9 years, 6 months ago (2011-06-21 15:58:18 UTC) #2
Mattias Nissler (ping if slow)
LGTM with a nit. http://codereview.chromium.org/7216012/diff/4/chrome/browser/policy/cloud_policy_subsystem_unittest.cc File chrome/browser/policy/cloud_policy_subsystem_unittest.cc (right): http://codereview.chromium.org/7216012/diff/4/chrome/browser/policy/cloud_policy_subsystem_unittest.cc#newcode221 chrome/browser/policy/cloud_policy_subsystem_unittest.cc:221: EXPECT_CALL(*(factory_.get()), Intercept(kGaiaAuthHeader, "register", _)). It ...
9 years, 6 months ago (2011-06-21 20:35:27 UTC) #3
gfeher
http://codereview.chromium.org/7216012/diff/4/chrome/browser/policy/cloud_policy_subsystem_unittest.cc File chrome/browser/policy/cloud_policy_subsystem_unittest.cc (right): http://codereview.chromium.org/7216012/diff/4/chrome/browser/policy/cloud_policy_subsystem_unittest.cc#newcode197 chrome/browser/policy/cloud_policy_subsystem_unittest.cc:197: // The first unexptected request of the policy subsystem ...
9 years, 6 months ago (2011-06-23 12:22:59 UTC) #4
commit-bot: I haz the power
9 years, 6 months ago (2011-06-23 14:44:30 UTC) #5
Change committed as 90211

Powered by Google App Engine
This is Rietveld 408576698