Test cases for the cloud policy subsystem

Test cases for the cloud policy subsystem

BUG=chromium-os:16637
TEST=compiles and passes


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90211

[gfeher, 2011-06-21 15:26:52]

Some of you please review this. It includes a lot of gtest and gmock fun!

[Joao da Silva, 2011-06-21 15:58:18]

LGTM, but please have a stamp from another reviewer too!

http://codereview.chromium.org/7216012/diff/4/chrome/browser/policy/cloud_pol...
File chrome/browser/policy/cloud_policy_subsystem_unittest.cc (right):

http://codereview.chromium.org/7216012/diff/4/chrome/browser/policy/cloud_pol...
chrome/browser/policy/cloud_policy_subsystem_unittest.cc:197: // The first
unexptected request of the policy subsystem will stop the
Nit: *unexpected

[Mattias Nissler (ping if slow), 2011-06-21 20:35:27]

LGTM with a nit.

http://codereview.chromium.org/7216012/diff/4/chrome/browser/policy/cloud_pol...
File chrome/browser/policy/cloud_policy_subsystem_unittest.cc (right):

http://codereview.chromium.org/7216012/diff/4/chrome/browser/policy/cloud_pol...
chrome/browser/policy/cloud_policy_subsystem_unittest.cc:221:
EXPECT_CALL(*(factory_.get()), Intercept(kGaiaAuthHeader, "register", _)).
It seems that most cases put the . on the next line, which I also find more
readable. I don't know what the more common form is though.

[gfeher, 2011-06-23 12:22:59]

http://codereview.chromium.org/7216012/diff/4/chrome/browser/policy/cloud_pol...
File chrome/browser/policy/cloud_policy_subsystem_unittest.cc (right):

http://codereview.chromium.org/7216012/diff/4/chrome/browser/policy/cloud_pol...
chrome/browser/policy/cloud_policy_subsystem_unittest.cc:197: // The first
unexptected request of the policy subsystem will stop the
On 2011/06/21 15:58:19, joaodasilva wrote:
> Nit: *unexpected

Done.

http://codereview.chromium.org/7216012/diff/4/chrome/browser/policy/cloud_pol...
chrome/browser/policy/cloud_policy_subsystem_unittest.cc:221:
EXPECT_CALL(*(factory_.get()), Intercept(kGaiaAuthHeader, "register", _)).
gmock_unittest.cc puts the . on the next lines, that's a good enough reason for
me to do the same...

[commit-bot: I haz the power, 2011-06-23 14:44:30]

Change committed as 90211