Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 721433002: Take text path into account when stripping spaces (Closed)

Created:
6 years, 1 month ago by eae
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Take text path into account when stripping spaces Take the text path (simple vs complex) into account when computing the width of a space character used to strip leading and trailing spaces. R=leviw@chromium.org BUG=427415 TEST=fast/text/international/complex-text-leading-space-wrapping.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185148

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1 line) Patch
A LayoutTests/fast/text/international/complex-text-leading-space-wrapping.html View 1 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/international/complex-text-leading-space-wrapping-expected.html View 1 1 chunk +26 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
eae
6 years, 1 month ago (2014-11-11 21:30:00 UTC) #1
leviw_travelin_and_unemployed
lgtm https://codereview.chromium.org/721433002/diff/1/LayoutTests/fast/text/international/complext-text-leading-space-wrapping-expected.html File LayoutTests/fast/text/international/complext-text-leading-space-wrapping-expected.html (right): https://codereview.chromium.org/721433002/diff/1/LayoutTests/fast/text/international/complext-text-leading-space-wrapping-expected.html#newcode19 LayoutTests/fast/text/international/complext-text-leading-space-wrapping-expected.html:19: <input type="checkbox" name="advanced" id="advanced-box"> nits: are name="advanced" and ...
6 years, 1 month ago (2014-11-11 21:33:42 UTC) #2
eae
On 2014/11/11 21:33:42, leviw wrote: > lgtm > > https://codereview.chromium.org/721433002/diff/1/LayoutTests/fast/text/international/complext-text-leading-space-wrapping-expected.html > File > LayoutTests/fast/text/international/complext-text-leading-space-wrapping-expected.html > ...
6 years, 1 month ago (2014-11-11 21:34:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721433002/40001
6 years, 1 month ago (2014-11-11 21:42:57 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 22:45:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as 185148

Powered by Google App Engine
This is Rietveld 408576698