Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 721393002: Disable GpuMetricsProvider if GPU is disabled. (Closed)

Created:
6 years, 1 month ago by GusFernandez
Modified:
6 years, 1 month ago
Reviewers:
lcwu1, lcwu, gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable GpuMetricsProvider if GPU is disabled. This was causing problems with some platforms in Aura's CreateNativeScreen if GPU metrics were collected before Aura is initialized. Committed: https://crrev.com/f26779fd0b76f282d82bb33169c8c88dee8ba903 Cr-Commit-Position: refs/heads/master@{#304125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chromecast/browser/metrics/cast_metrics_service_client.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
GusFernandez
6 years, 1 month ago (2014-11-13 22:11:46 UTC) #2
lcwu1
lgtm
6 years, 1 month ago (2014-11-13 22:14:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721393002/1
6 years, 1 month ago (2014-11-13 22:22:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-14 00:29:43 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 00:30:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f26779fd0b76f282d82bb33169c8c88dee8ba903
Cr-Commit-Position: refs/heads/master@{#304125}

Powered by Google App Engine
This is Rietveld 408576698