Source/core/paint/LayerPainter.h - Issue 721363002: [New Multicolumn] Make rounded corners clipping multicol-aware.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/LayerPainter.h

Issue 721363002: [New Multicolumn] Make rounded corners clipping multicol-aware. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: code review Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/multicol/border-radius-clipped-layer-expected.html ('K') | « Source/core/paint/FilterPainter.cpp ('k') | Source/core/paint/LayerPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/paint/LayerPainter.h

diff --git a/Source/core/paint/LayerPainter.h b/Source/core/paint/LayerPainter.h

index fae2c89d0581be795d36203ec145b04166aca746..ab15b766d7e3cb1a86ac80d98863bd48a3e34ff2 100644

--- a/Source/core/paint/LayerPainter.h

+++ b/Source/core/paint/LayerPainter.h

@@ -30,7 +30,7 @@ public:

void paintOverlayScrollbars(GraphicsContext*, const LayoutRect& damageRect, PaintBehavior, RenderObject* paintingRoot = 0);

enum BorderRadiusClippingRule { IncludeSelfForBorderRadius, DoNotIncludeSelfForBorderRadius };

- static void applyRoundedRectClips(RenderLayer&, const LayerPaintingInfo&, GraphicsContext*, PaintLayerFlags, ClipRecorder&, BorderRadiusClippingRule = IncludeSelfForBorderRadius);

+ static void applyRoundedRectClips(RenderLayer&, const LayerPaintingInfo&, GraphicsContext*, const LayoutPoint& fragmentOffset, PaintLayerFlags, ClipRecorder&, BorderRadiusClippingRule = IncludeSelfForBorderRadius);

chrishtr 2014/11/14 20:18:21 Please document what the fragmentOffset is from.

mstensho (USE GERRIT) 2014/11/14 23:16:20 Done. Made me realize that the BorderRadiusClippin

static void beginTransparencyLayers(GraphicsContext*, RenderLayer&, const RenderLayer* rootLayer, const LayoutRect& paintDirtyRect, const LayoutSize& subPixelAccumulation, PaintBehavior);

private: