[New Multicolumn] Make rounded corners clipping multicol-aware.

Source/core/paint/LayerPainter.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef LayerPainter_h
 #define LayerPainter_h
 
 #include "core/paint/ClipRecorder.h"
 #include "core/rendering/LayerFragment.h"
 #include "core/rendering/LayerPaintingInfo.h"
@@ skipping 12 matching lines @@
     //  paint() assumes that the caller will clip to the bounds of damageRect if necessary.
     void paint(GraphicsContext*, const LayoutRect& damageRect, PaintBehavior = PaintBehaviorNormal, RenderObject* paintingRoot = 0, PaintLayerFlags = 0);
     // paintLayer() assumes that the caller will clip to the bounds of the painting dirty if necessary.
     void paintLayer(GraphicsContext*, const LayerPaintingInfo&, PaintLayerFlags);
     // paintLayerContents() assumes that the caller will clip to the bounds of the painting dirty rect if necessary.
     void paintLayerContents(GraphicsContext*, const LayerPaintingInfo&, PaintLayerFlags);
 
     void paintOverlayScrollbars(GraphicsContext*, const LayoutRect& damageRect, PaintBehavior, RenderObject* paintingRoot = 0);
 
     enum BorderRadiusClippingRule { IncludeSelfForBorderRadius, DoNotIncludeSelfForBorderRadius };
-    static void applyRoundedRectClips(RenderLayer&, const LayerPaintingInfo&, GraphicsContext*, PaintLayerFlags, ClipRecorder&, BorderRadiusClippingRule = IncludeSelfForBorderRadius);
+
+    // Set rounded clip rectangles defined by border radii all the way from the LayerPaintingInfo

[chrishtr, 2014/11/14 23:22:26]

Aside, unrelated to your CL: why are we setting it all the way from the root?
Why is the root not painting its own rounded corners before recursion? Don't
quite get it, do you?

[mstensho (USE GERRIT), 2014/11/14 23:36:58]

Both rectangular and rounded clip rectangles are applied all the way from the
"root" [1] for all layers, I think. The reason has to be that different
descendant layers are affected differently by ancestors' clipping. E.g. an
absolutely positioned box "CHILD1" inside a statically positioned box "PARENT"
with overflow:hidden isn't clipped by "PARENT", while a relatively positioned
"CHILD2" of the same "PARENT" will get clipped by it.

[1] "root" is not root when we transform. Then "root" becomes the transformed
layer.

Note that this it not about actually painting the borders. That's done locally
on every layer. This is only about clipping along the inner edges of the borders
when painting child content.

+    // "root" layer down to the specified layer (or the parent of said layer, in case
+    // BorderRadiusClippingRule says to skip self). fragmentOffset is used for multicol, to specify
+    // the translation required to get from flow thread coordinates to visual coordinates for a
+    // certain column.
+    // FIXME: The BorderRadiusClippingRule parameter is really useless now. If we want to skip self,
+    // why not just supply the parent layer as the first parameter instead?
+    static void applyRoundedRectClips(RenderLayer&, const LayerPaintingInfo&, GraphicsContext*, const LayoutPoint& fragmentOffset, PaintLayerFlags, ClipRecorder&, BorderRadiusClippingRule = IncludeSelfForBorderRadius);
+
     static void beginTransparencyLayers(GraphicsContext*, RenderLayer&, const RenderLayer* rootLayer, const LayoutRect& paintDirtyRect, const LayoutSize& subPixelAccumulation, PaintBehavior);
 
 private:
     enum ClipState { HasNotClipped, HasClipped };
 
     void paintLayerContentsAndReflection(GraphicsContext*, const LayerPaintingInfo&, PaintLayerFlags);
     void paintLayerByApplyingTransform(GraphicsContext*, const LayerPaintingInfo&, PaintLayerFlags, const LayoutPoint& translationOffset = LayoutPoint());
 
     void paintChildren(unsigned childrenToVisit, GraphicsContext*, const LayerPaintingInfo&, PaintLayerFlags);
     void paintPaginatedChildLayer(RenderLayer* childLayer, GraphicsContext*, const LayerPaintingInfo&, PaintLayerFlags);
@@ skipping 17 matching lines @@
     // Returns whether this layer should be painted during sofware painting (i.e., not via calls from CompositedLayerMapping to draw into composited
     // layers).
     bool shouldPaintLayerInSoftwareMode(const LayerPaintingInfo&, PaintLayerFlags paintFlags);
 
     RenderLayer& m_renderLayer;
 };
 
 } // namespace blink
 
 #endif // LayerPainter_h