Issue 721333004: Subzero: Fix a bug in postLower().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 721333004: Subzero: Fix a bug in postLower(). (Closed)

Created:
6 years ago by Jim Stichnoth

Modified:
6 years ago

Reviewers:
jvoung (off chromium), Karl

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

Subzero: Fix a bug in postLower(). In -O2 mode, postLower() is supposed to iterate over just the instructions that were most recently added. Instead, it was iterating all the way to the end of the block, also post-lowering high-level ICE instructions that hadn't yet been lowered. This was basically harmless, given that the spec2k asm code is identical after this patch, but it improves performance. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=5d2fa0cfe93b63a0db3527dd83f5d535f4b8663b

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	src/IceTargetLowering.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	src/IceTargetLoweringX8632.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

6 years ago (2014-12-01 17:31:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5d2fa0cfe93b63a0db3527dd83f5d535f4b8663b (presubmit successful).