Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: net/udp/udp_socket_unittest.cc

Issue 721273002: Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer options from UDPSocket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/udp/udp_socket_unittest.cc
diff --git a/net/udp/udp_socket_unittest.cc b/net/udp/udp_socket_unittest.cc
index 83689c7aacc3dd7732aeee75054ceab709e73c0f..48618e2dc901c00b6f0b196be0322d65f34b948e 100644
--- a/net/udp/udp_socket_unittest.cc
+++ b/net/udp/udp_socket_unittest.cc
@@ -217,7 +217,10 @@ TEST_F(UDPSocketTest, DISABLED_Broadcast) {
TEST_F(UDPSocketTest, Broadcast) {
#endif
const int kPort = 9999;
- std::string first_message("first message"), second_message("second message");
+ std::string first_message("first message");
+ std::string second_message("second message");
+ std::string third_message("third message");
+ std::string fourth_message("fourth message");
IPEndPoint broadcast_address;
CreateUDPAddress("255.255.255.255", kPort, &broadcast_address);
@@ -230,11 +233,13 @@ TEST_F(UDPSocketTest, Broadcast) {
scoped_ptr<UDPServerSocket> server2(
new UDPServerSocket(&server2_log, NetLog::Source()));
server1->AllowAddressReuse();
- server1->AllowBroadcast();
+ int rv = server1->SetBroadcast(true);
+ ASSERT_EQ(OK, rv);
server2->AllowAddressReuse();
- server2->AllowBroadcast();
+ rv = server2->SetBroadcast(true);
+ ASSERT_EQ(OK, rv);
- int rv = server1->Listen(listen_address);
+ rv = server1->Listen(listen_address);
EXPECT_EQ(OK, rv);
rv = server2->Listen(listen_address);
EXPECT_EQ(OK, rv);
@@ -252,6 +257,15 @@ TEST_F(UDPSocketTest, Broadcast) {
ASSERT_EQ(second_message, str);
str = RecvFromSocket(server2.get());
ASSERT_EQ(second_message, str);
+
+ rv = server1->SetBroadcast(false);
+ ASSERT_EQ(OK, rv);
+ rv = server2->SetBroadcast(false);
+ ASSERT_EQ(OK, rv);
+ rv = SendToSocket(server1.get(), third_message, broadcast_address);
+ ASSERT_LT(rv, 0);
+ rv = SendToSocket(server2.get(), fourth_message, broadcast_address);
+ ASSERT_LT(rv, 0);
}
// In this test, we verify that random binding logic works, which attempts

Powered by Google App Engine
This is Rietveld 408576698