net/udp/datagram_server_socket.h - Issue 721273002: Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer options from UDPSocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/udp/datagram_server_socket.h

Issue 721273002: Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer options from UDPSocket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/udp/datagram_server_socket.h

diff --git a/net/udp/datagram_server_socket.h b/net/udp/datagram_server_socket.h

index d3796c363281e7e84c5bdeb3549834fdeac240cb..433d5dde03d4cf47d6f9a33335bf86896c534de1 100644

--- a/net/udp/datagram_server_socket.h

+++ b/net/udp/datagram_server_socket.h

@@ -68,8 +68,8 @@ class NET_EXPORT DatagramServerSocket : public DatagramSocket {

virtual void AllowAddressReuse() = 0;

// Allow sending and receiving packets to and from broadcast addresses.

- // Should be called before Listen().

- virtual void AllowBroadcast() = 0;

+ // Returns a net error code.

+ virtual int SetBroadcast(bool broadcast) = 0;

// Join the multicast group with address |group_address|.

// Returns a network error code.

« no previous file with comments | « net/dns/mock_mdns_socket_factory.h ('k') | net/udp/udp_server_socket.h » ('j') | net/udp/udp_socket_win.cc » ('J')