Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer options from UDPSocket.

extensions/browser/api/socket/udp_socket.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/socket/udp_socket.h"
 
 #include <algorithm>
 
 #include "base/lazy_instance.h"
 #include "extensions/browser/api/api_resource.h"
@@ skipping 31 matching lines @@
   do {
     if (is_connected_)
       break;
 
     net::IPEndPoint ip_end_point;
     if (!StringAndPortToIPEndPoint(address, port, &ip_end_point)) {
       result = net::ERR_ADDRESS_INVALID;
       break;
     }
 
+    result = socket_.Open(ip_end_point.GetFamily());
+    if (result != net::OK)
+      break;
+
     result = socket_.Connect(ip_end_point);
-    is_connected_ = (result == net::OK);
+    if (result != net::OK) {
+      socket_.Close();
+      break;
+    }
+    is_connected_ = true;
   } while (false);
 
   callback.Run(result);
 }
 
 int UDPSocket::Bind(const std::string& address, uint16 port) {
   if (IsBound())
     return net::ERR_CONNECTION_FAILED;
 
   net::IPEndPoint ip_end_point;
   if (!StringAndPortToIPEndPoint(address, port, &ip_end_point))
     return net::ERR_INVALID_ARGUMENT;
 
-  return socket_.Bind(ip_end_point);
+  int result = socket_.Open(ip_end_point.GetFamily());
+  if (result != net::OK)
+    return result;
+
+  result = socket_.Bind(ip_end_point);
+  if (result != net::OK)
+    socket_.Close();
+  return result;
 }
 
 void UDPSocket::Disconnect() {
   is_connected_ = false;
   socket_.Close();
   read_callback_.Reset();
   recv_from_callback_.Reset();
   send_to_callback_.Reset();
   multicast_groups_.clear();
 }
@@ skipping 210 matching lines @@
 
 ResumableUDPSocket::ResumableUDPSocket(const std::string& owner_extension_id)
     : UDPSocket(owner_extension_id),
       persistent_(false),
       buffer_size_(0),
       paused_(false) {}
 
 bool ResumableUDPSocket::IsPersistent() const { return persistent(); }
 
 }  // namespace extensions