Issue 721243003: Changes ViewManagerServiceImpl so that it no longer subclasses InterfaceImpl

Issue 721243003: Changes ViewManagerServiceImpl so that it no longer subclasses InterfaceImpl (Closed)

Created:
6 years, 1 month ago by sky

Modified:
6 years, 1 month ago

Reviewers:
msw

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Changes ViewManagerServiceImpl so that it no longer subclasses InterfaceImpl This is part 1 of refactoring view manager server. R=msw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5f5ce57985e72f230aff1695e93f1bdfba140963

Patch Set 2 : format #

Total comments: 12

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+207 lines, -127 lines)			Patch
M	mojo/services/view_manager/BUILD.gn	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	mojo/services/view_manager/client_connection.h	View		1 chunk	+65 lines, -0 lines	8 comments	Download
A	mojo/services/view_manager/client_connection.cc	View	1	1 chunk	+37 lines, -0 lines	2 comments	Download
M	mojo/services/view_manager/connection_manager.h	View	1	6 chunks	+13 lines, -16 lines	0 comments	Download
M	mojo/services/view_manager/connection_manager.cc	View	1	14 chunks	+73 lines, -90 lines	0 comments	Download
M	mojo/services/view_manager/view_manager_service_impl.h	View		4 chunks	+10 lines, -11 lines	2 comments	Download
M	mojo/services/view_manager/view_manager_service_impl.cc	View		4 chunks	+7 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

msw

lgtm with nits https://codereview.chromium.org/721243003/diff/20001/mojo/services/view_manager/client_connection.cc File mojo/services/view_manager/client_connection.cc (right): https://codereview.chromium.org/721243003/diff/20001/mojo/services/view_manager/client_connection.cc#newcode21 mojo/services/view_manager/client_connection.cc:21: ConnectionManager* connection_manager, nit: swap the arg ...

6 years, 1 month ago (2014-11-14 01:42:18 UTC) #2

sky

Committed patchset #2 (id:20001) manually as 5f5ce57985e72f230aff1695e93f1bdfba140963 (presubmit successful).

6 years, 1 month ago (2014-11-14 02:01:30 UTC) #3

sky

6 years, 1 month ago (2014-11-14 20:56:04 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/721243003/diff/20001/mojo/services/view_manag...
File mojo/services/view_manager/client_connection.cc (right):

https://codereview.chromium.org/721243003/diff/20001/mojo/services/view_manag...
mojo/services/view_manager/client_connection.cc:21: ConnectionManager*
connection_manager,
On 2014/11/14 01:42:18, msw wrote:
> nit: swap the arg order to match the base class and init list use.

Done.

https://codereview.chromium.org/721243003/diff/20001/mojo/services/view_manag...
File mojo/services/view_manager/client_connection.h (right):

https://codereview.chromium.org/721243003/diff/20001/mojo/services/view_manag...
mojo/services/view_manager/client_connection.h:45:
scoped_ptr<ViewManagerServiceImpl> service_impl);
On 2014/11/14 01:42:18, msw wrote:
> nit: make this match ClientConnection's |service| or vice-versa.

Done.

https://codereview.chromium.org/721243003/diff/20001/mojo/services/view_manag...
mojo/services/view_manager/client_connection.h:48: Binding<ViewManagerService>*
binding() { return &binding_; }
On 2014/11/14 01:42:18, msw wrote:
> nit: consider having two ctors (or two helper Bind functions) that'll take the
> Handle or InterfaceRequest to encapsulate the binding and client setting.

I'll do that in a subsequent patch when the delegate ends up creating these.

https://codereview.chromium.org/721243003/diff/20001/mojo/services/view_manag...
mojo/services/view_manager/client_connection.h:50: void SetClient() {
set_client(binding_.client()); }
On 2014/11/14 01:42:18, msw wrote:
> nit: consider set_client_from_binding()

Done.

https://codereview.chromium.org/721243003/diff/20001/mojo/services/view_manag...
mojo/services/view_manager/client_connection.h:53: // InterfaceBindingDelegate:
On 2014/11/14 01:42:18, msw wrote:
> nit: ErrorHandler

Done.

https://codereview.chromium.org/721243003/diff/20001/mojo/services/view_manag...
File mojo/services/view_manager/view_manager_service_impl.h (right):

https://codereview.chromium.org/721243003/diff/20001/mojo/services/view_manag...
mojo/services/view_manager/view_manager_service_impl.h:31: // Manages a
connection from the client.
On 2014/11/14 01:42:18, msw wrote:
> nit: perhaps expand on this comment?

Done.

Expand Messages | Collapse Messages