runtime/vm/flow_graph_compiler_ia32.cc - Issue 721233002: Write barrier audit: Verify previous value in generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 721233002: Write barrier audit: Verify previous value in generated code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_ia32.cc

===================================================================

--- runtime/vm/flow_graph_compiler_ia32.cc (revision 41779)

+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)

@@ -1234,6 +1234,7 @@

intptr_t increment_start = assembler_->CodeSize();

#endif // DEBUG

__ IncrementSmiField(FieldAddress(EAX, Array::element_offset(0)), 1);

+ // If the assertion below fails, update EdgeCounterIncrementSizeInBytes.

DEBUG_ASSERT((assembler_->CodeSize() - increment_start) ==

EdgeCounterIncrementSizeInBytes());

}

@@ -1240,7 +1241,8 @@

int32_t FlowGraphCompiler::EdgeCounterIncrementSizeInBytes() {

- return VerifiedMemory::enabled() ? 16 : 4;

+ // Used by CodePatcher; so must be constant across all code in an isolate.

+ return VerifiedMemory::enabled() ? 50 : 4;

}

« no previous file with comments | « runtime/vm/assembler_ia32.cc ('k') | runtime/vm/intrinsifier_ia32.cc » ('j') | no next file with comments »