Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: runtime/vm/assembler_ia32.h

Issue 721233002: Write barrier audit: Verify previous value in generated code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_ia32.h
===================================================================
--- runtime/vm/assembler_ia32.h (revision 41779)
+++ runtime/vm/assembler_ia32.h (working copy)
@@ -626,10 +626,12 @@
void int3();
void hlt();
+ // Note: verified_mem mode forces far jumps.
void j(Condition condition, Label* label, bool near = kFarJump);
void j(Condition condition, const ExternalLabel* label);
void jmp(Register reg);
+ // Note: verified_mem mode forces far jumps.
void jmp(Label* label, bool near = kFarJump);
void jmp(const ExternalLabel* label);
@@ -929,7 +931,9 @@
Register value,
Label* no_update);
- // Private helpers for write barrier verification.
+ // Analogous to VerifiedMemory::Verify(address, kWordSize).
+ void VerifyHeapWord(const Address& address);
+ // Analogous to VerifiedMemory::Write.
void VerifiedWrite(const Address& dest, Register value);
void UnverifiedStoreOldObject(const Address& dest, const Object& value);
« no previous file with comments | « no previous file | runtime/vm/assembler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698