Work in progress for end-to-end bindings

mojo/shell/app_container.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_SHELL_APP_CONTAINER_H_
 #define MOJO_SHELL_APP_CONTAINER_H_
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
+#include "base/threading/simple_thread.h"
+#include "mojo/examples/hello_world_service/hello_world_service_impl.h"
 #include "mojo/public/system/core.h"
 #include "mojo/shell/loader.h"
 
 namespace base {
 class FilePath;
-class Thread;
+class PlatformThreadHandle;
 }
 
 namespace mojo {
 namespace services {
 class NativeViewportController;
 }
 namespace shell {
 
 class Context;
 
 // A container class that runs an app on its own thread.
-class AppContainer : public Loader::Delegate {
+class AppContainer
+    : public Loader::Delegate,
+      public base::DelegateSimpleThread::Delegate {
  public:
   explicit AppContainer(Context* context);
   virtual ~AppContainer();
 
   void Load(const GURL& app_url);
 
  private:
-  // From Loader::Delegate
+  // From Loader::Delegate.
   virtual void DidCompleteLoad(const GURL& app_url,
                                const base::FilePath& app_path) OVERRIDE;
 
+  // From base::DelegateSimpleThread::Delegate.
+  virtual void Run() OVERRIDE;

[sky, 2013/11/15 17:11:56]

In hopes of making code easier to maintain and reason about is it possible to
move all the code/data that runs on the background into a separate object?

[DaveMoore, 2013/11/15 17:15:24]

As said in comment, this is a WIP. When we make it real, we'll certainly do
that. This is basically to prove out an approach.

On 2013/11/15 17:11:56, sky wrote:

+
   void AppCompleted();
 
   Context* context_;
+  base::FilePath app_path_;
+  Handle app_handle_raw_;
+  base::Closure ack_closure_;
   scoped_ptr<Loader::Job> request_;
-  scoped_ptr<base::Thread> thread_;
+  scoped_ptr<base::DelegateSimpleThread> thread_;
+  scoped_ptr<examples::HelloWorldServiceImpl> hello_world_service_;

[sky, 2013/11/15 17:11:56]

How come the appcontainer is depending upon an example?

[abarth-chromium, 2013/11/15 17:14:34]

It's just temporary while we bring up the service manager.

[DaveMoore, 2013/11/15 17:15:24]

WIP. Next we will generalize and no longer have that dependency.

On 2013/11/15 17:11:56, sky wrote:

   scoped_ptr<services::NativeViewportController> native_viewport_controller_;
 
-  // Following members are valid only on app thread.
-  Handle shell_handle_;
-
   base::WeakPtrFactory<AppContainer> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AppContainer);
 };
 
 }  // namespace shell
 }  // namespace mojo
 
 #endif  // MOJO_SHELL_APP_CONTAINER_H_