Work in progress for end-to-end bindings

mojo/examples/sample_app/sample_app.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdio.h>
 #include <string>
 
 #include "base/message_loop/message_loop.h"
 #include "mojo/common/bindings_support_impl.h"
 #include "mojo/examples/sample_app/hello_world_client_impl.h"
 #include "mojo/public/bindings/lib/bindings_support.h"
 #include "mojo/public/system/core.h"
 #include "mojo/public/system/macros.h"
 
 #if defined(WIN32)
 #if !defined(CDECL)
 #define CDECL __cdecl
 #endif
 #define SAMPLE_APP_EXPORT __declspec(dllexport)
 #else
 #define CDECL
 #define SAMPLE_APP_EXPORT __attribute__((visibility("default")))
 #endif
 
 namespace mojo {
 namespace examples {
 
-static HelloWorldClientImpl* g_client = 0;
-
 void SayHello(mojo::Handle pipe) {
-  g_client = new HelloWorldClientImpl(pipe);
-
+  base::MessageLoop loop;

[darin (slow to review), 2013/11/15 00:01:37]

it would be rational for BindingsSupportImpl to assert that the current thread
has a MessageLoop since it doesn't work without one. you might want to allocate
the MessageLoop in MojoMain for that reason.

[DaveMoore, 2013/11/15 00:11:33]

Done.

+  // Send message out.
+  HelloWorldClientImpl client(pipe);
   mojo::ScratchBuffer buf;
   const std::string kGreeting("hello, world!");
   mojo::String* greeting = mojo::String::NewCopyOf(&buf, kGreeting);
+  client.service()->Greeting(greeting);
 
-  g_client->service()->Greeting(greeting);
+  // Run loop to receieve Ack. The client will quit the loop.
+  loop.Run();
 }
 
 }  // examples
 }  // mojo
 
 extern "C" SAMPLE_APP_EXPORT MojoResult CDECL MojoMain(
     mojo::Handle pipe) {
-  // Create a message loop on this thread for processing incoming messages.
-  // This creates a dependency on base that we'll be removing soon.
-  base::MessageLoop loop;
-
+  printf("here!\n");

[abarth-chromium, 2013/11/14 23:59:05]

We probably want to remove this before landing.  :)

[DaveMoore, 2013/11/15 00:11:33]

Done.

   // Set the global bindings support.
   mojo::common::BindingsSupportImpl bindings_support;
   mojo::BindingsSupport::Set(&bindings_support);
 
-  // Send message out.
   mojo::examples::SayHello(pipe);
 
-  // Run loop to receieve Ack.
-  loop.Run();
-
   mojo::BindingsSupport::Set(NULL);
   return MOJO_RESULT_OK;
 }