pkg/http_server/test/http_mock.dart - Issue 721213002: Fix a number of issues with the Range header handling for serving files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/http_server/test/http_mock.dart

Issue 721213002: Fix a number of issues with the Range header handling for serving files (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix test Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/http_server/lib/src/virtual_directory.dart ('K') | « pkg/http_server/lib/src/virtual_directory.dart ('k') | pkg/http_server/test/utils.dart » ('j') | pkg/http_server/test/utils.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/http_server/test/http_mock.dart

diff --git a/pkg/http_server/test/http_mock.dart b/pkg/http_server/test/http_mock.dart

index aa20ffb57bfa1323ea962d94160e4c6b529da1fc..1f9a8d03ce9af972eb54905af0be0e992ca71778 100644

--- a/pkg/http_server/test/http_mock.dart

+++ b/pkg/http_server/test/http_mock.dart

@@ -9,6 +9,7 @@ class MockHttpHeaders implements HttpHeaders {

final Map<String, List<String>> _headers =

new HashMap<String, List<String>>();

+ operator[](key) => _headers[key];

DateTime get ifModifiedSince {

List<String> values = _headers[HttpHeaders.IF_MODIFIED_SINCE];

@@ -182,6 +183,8 @@ class MockHttpResponse implements HttpResponse {

String get mockContent => UTF8.decode(_buffer);

+ String get mockContentBinary => _buffer;

kustermann 2014/11/14 13:25:27 That seems wrong. [_buffer] is of type List<int>

Søren Gjesse 2014/11/14 15:27:29 Fixed. The beauty of ignoring the analyzer.

bool get mockDone => _isDone;

// Copied from SDK http_impl.dart @ 845 on 2014-01-05

« pkg/http_server/lib/src/virtual_directory.dart ('K') | « pkg/http_server/lib/src/virtual_directory.dart ('k') | pkg/http_server/test/utils.dart » ('j') | pkg/http_server/test/utils.dart » ('J')