Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 721133003: DevTools: CssChecker: avoid selector crafting in AuditsPanel. (Closed)

Created:
6 years, 1 month ago by eustas
Modified:
6 years, 1 month ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: CssChecker: avoid selector crafting in AuditsPanel. BUG=405921 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185422

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M LayoutTests/inspector/audits/audits-panel-functional-expected.txt View 1 3 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/inspector/audits/audits-panel-noimages-functional-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-audits-content-script-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/extensions/extensions-audits-expected.txt View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/audits/AuditResultView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/audits/auditsPanel.css View 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
eustas
6 years, 1 month ago (2014-11-13 15:48:52 UTC) #2
eustas
Friendly ping.
6 years, 1 month ago (2014-11-14 16:36:40 UTC) #3
apavlov
lgtm
6 years, 1 month ago (2014-11-14 17:06:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721133003/1
6 years, 1 month ago (2014-11-14 17:07:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/33674)
6 years, 1 month ago (2014-11-14 18:01:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721133003/20001
6 years, 1 month ago (2014-11-17 06:18:30 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 07:24:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185422

Powered by Google App Engine
This is Rietveld 408576698