Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 721133002: bindings: preparation for fixing incorrect dependency of SerializedScriptValue. (Closed)

Created:
6 years, 1 month ago by tasak
Modified:
6 years, 1 month ago
Reviewers:
haraken, jsbell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

bindings: preparation for fixing incorrect dependency of SerializedScriptValue. Split Writer, Reader, Serializer and Deserializer off from SerializedScriptValue.cpp. The goal is https://codereview.chromium.org/718383003/ BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185349

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3129 lines, -2851 lines) Patch
A Source/bindings/core/v8/ScriptValueSerializer.h View 1 1 chunk +607 lines, -0 lines 0 comments Download
A Source/bindings/core/v8/ScriptValueSerializer.cpp View 1 1 chunk +2338 lines, -0 lines 0 comments Download
A Source/bindings/core/v8/SerializationTag.h View 1 1 chunk +158 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/SerializedScriptValue.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/SerializedScriptValue.cpp View 1 6 chunks +19 lines, -2851 lines 0 comments Download
M Source/bindings/core/v8/v8.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tasak
Would you review this CL?
6 years, 1 month ago (2014-11-13 10:53:38 UTC) #3
haraken
LGTM
6 years, 1 month ago (2014-11-13 11:21:29 UTC) #4
jsbell
lgtm https://codereview.chromium.org/721133002/diff/20001/Source/bindings/core/v8/SerializedScriptValue.cpp File Source/bindings/core/v8/SerializedScriptValue.cpp (right): https://codereview.chromium.org/721133002/diff/20001/Source/bindings/core/v8/SerializedScriptValue.cpp#newcode60 Source/bindings/core/v8/SerializedScriptValue.cpp:60: // NOTE: be sure to change wireFormatVersion as ...
6 years, 1 month ago (2014-11-13 23:22:43 UTC) #5
tasak
Thank you for review. https://codereview.chromium.org/721133002/diff/20001/Source/bindings/core/v8/SerializedScriptValue.cpp File Source/bindings/core/v8/SerializedScriptValue.cpp (right): https://codereview.chromium.org/721133002/diff/20001/Source/bindings/core/v8/SerializedScriptValue.cpp#newcode60 Source/bindings/core/v8/SerializedScriptValue.cpp:60: // NOTE: be sure to ...
6 years, 1 month ago (2014-11-14 04:26:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721133002/40001
6 years, 1 month ago (2014-11-14 04:27:31 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 05:39:21 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as 185349

Powered by Google App Engine
This is Rietveld 408576698