GN: Have android_apk always look for stripped libraries.

GN: Have android_apk always look for stripped libraries.

R=cjhopman@chromium.org
TBR=tedchoc@chromium.org

Committed: https://crrev.com/acc3fd852e38c4df2246412376c6429926c99a8c
Cr-Commit-Position: refs/heads/master@{#304405}

[cjhopman, 2014-11-13 19:27:37]

https://codereview.chromium.org/721123002/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/721123002/diff/1/build/config/android/rules.g...
build/config/android/rules.gni:1226: #   unittests_binary: The name of the
binary produced by the unittests_dep
This documentation needs to be updated. The unittests_binary should now just be
the basename of the library (since we are going to throw away the rest).

https://codereview.chromium.org/721123002/diff/1/build/config/android/rules.g...
build/config/android/rules.gni:1248: unittests_binary = root_out_dir +
"/lib.stripped/lib" + test_suite_name + ".so"
this can just calculate the basename

https://codereview.chromium.org/721123002/diff/1/build/config/android/rules.g...
build/config/android/rules.gni:1259: native_libs = [unittests_outputs[0]]
unittests_outputs isn't actually used. This can just be native_libs = [
unittests_binary ]

[qsr, 2014-11-14 10:39:33]

https://codereview.chromium.org/721123002/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/721123002/diff/1/build/config/android/rules.g...
build/config/android/rules.gni:1226: #   unittests_binary: The name of the
binary produced by the unittests_dep
On 2014/11/13 19:27:37, cjhopman wrote:
> This documentation needs to be updated. The unittests_binary should now just
be
> the basename of the library (since we are going to throw away the rest).

Done.

https://codereview.chromium.org/721123002/diff/1/build/config/android/rules.g...
build/config/android/rules.gni:1248: unittests_binary = root_out_dir +
"/lib.stripped/lib" + test_suite_name + ".so"
On 2014/11/13 19:27:37, cjhopman wrote:
> this can just calculate the basename

Done.

https://codereview.chromium.org/721123002/diff/1/build/config/android/rules.g...
build/config/android/rules.gni:1259: native_libs = [unittests_outputs[0]]
On 2014/11/13 19:27:37, cjhopman wrote:
> unittests_outputs isn't actually used. This can just be native_libs = [
> unittests_binary ]

Done.

[cjhopman, 2014-11-14 21:58:17]

lgtm

[qsr, 2014-11-17 09:47:55]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-11-17 09:48:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/721123002/20001

[commit-bot: I haz the power, 2014-11-17 09:51:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-17 09:51:55]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[qsr, 2014-11-17 09:59:15]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-11-17 09:59:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/721123002/20001

[commit-bot: I haz the power, 2014-11-17 10:58:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-17 11:00:09]

Patchset 2 (id:??) landed as
https://crrev.com/acc3fd852e38c4df2246412376c6429926c99a8c
Cr-Commit-Position: refs/heads/master@{#304405}