Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 721103003: [ServiceWorker] Serialize request.referrer to "about:client" when it's client. (Closed)

Created:
6 years, 1 month ago by horo
Modified:
6 years, 1 month ago
Reviewers:
nhiroki
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Serialize request.referrer to "about:client" when it's client. The spec of Fetch has been changed. https://github.com/whatwg/fetch/commit/30c35ec10994d0005f45879778424e8fc7272bde This change also renames "none" in "no referrer". https://github.com/whatwg/fetch/commit/0576c5aaf0c21545001beb73aae9d8b585c6ece5 BUG=N/A TEST=http/tests/serviceworker Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185282

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -28 lines) Patch
M LayoutTests/http/tests/serviceworker/request-end-to-end.html View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/request-end-to-end-worker.js View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/request-worker.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/FetchRequestData.h View 1 3 chunks +7 lines, -9 lines 0 comments Download
M Source/modules/serviceworkers/FetchRequestData.cpp View 1 2 chunks +1 line, -14 lines 0 comments Download
M Source/modules/serviceworkers/Request.cpp View 1 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
horo
nhiroki@ Could you please review?
6 years, 1 month ago (2014-11-13 08:06:22 UTC) #2
nhiroki
lgtm
6 years, 1 month ago (2014-11-13 08:25:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721103003/1
6 years, 1 month ago (2014-11-13 08:45:26 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/modules/serviceworkers/FetchRequestData.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 1 month ago (2014-11-13 09:42:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721103003/20001
6 years, 1 month ago (2014-11-13 09:52:33 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 11:59:08 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185282

Powered by Google App Engine
This is Rietveld 408576698