dart2js: simplify ssa-generate constant.

pkg/compiler/lib/src/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 class SsaCodeGeneratorTask extends CompilerTask {
 
   final JavaScriptBackend backend;
 
@@ skipping 1795 matching lines @@
 
   js.Expression newLiteralBool(bool value) {
     if (compiler.enableMinification) {
       // Use !0 for true, !1 for false.
       return new js.Prefix("!", new js.LiteralNumber(value ? "0" : "1"));
     } else {
       return new js.LiteralBool(value);
     }
   }
 
-  void generateConstant(ConstantValue constant) {
-    if (constant.isFunction) {
-      FunctionConstantValue function = constant;
-      registry.registerStaticUse(function.element);
-    }
-    if (constant.isType) {

[Johnni Winther, 2014/11/14 08:33:32]

We need to move this to JavaScriptBackend.registerCompileTimeConstantInternal
under a flag that the constant occurred in executed code (i.e. not in metadata).
It is needed to detect registration of custom elements.

-      // If the type is a web component, we need to ensure the constructors are
-      // available to 'upgrade' the native object.
-      TypeConstantValue type = constant;
-      Element element = type.representedType.element;
-      if (element != null && element.isClass) {
-        registry.registerTypeConstant(element);
-      }
-    }
-    push(backend.emitter.constantReference(constant));
-  }
-
   visitConstant(HConstant node) {
     assert(isGenerateAtUseSite(node));
-    generateConstant(node.constant);
-
+    push(backend.emitter.constantReference(node.constant));
     registry.registerCompileTimeConstant(node.constant);
     backend.constants.addCompileTimeConstantForEmission(node.constant);
   }
 
   visitNot(HNot node) {
     assert(node.inputs.length == 1);
     generateNot(node.inputs[0]);
     attachLocationToLast(node);
   }
 
@@ skipping 877 matching lines @@
   js.PropertyAccess accessHelper(String name) {
     Element helper = backend.findHelper(name);
     if (helper == null) {
       // For mocked-up tests.
       return js.js('(void 0).$name');
     }
     registry.registerStaticUse(helper);
     return backend.namer.elementAccess(helper);
   }
 }