Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4968)

Unified Diff: chrome/browser/ui/app_list/start_page_service.cc

Issue 721093002: Disable new hotwording in the launcher for non-ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/start_page_service.cc
diff --git a/chrome/browser/ui/app_list/start_page_service.cc b/chrome/browser/ui/app_list/start_page_service.cc
index 09c66ca0cf5e9bd799579033518de37491075e47..562030e32819e7fb6f4689ba6aeda52b45ee20ea 100644
--- a/chrome/browser/ui/app_list/start_page_service.cc
+++ b/chrome/browser/ui/app_list/start_page_service.cc
@@ -202,13 +202,15 @@ void StartPageService::ToggleSpeechRecognition() {
}
bool StartPageService::HotwordEnabled() {
+// Voice input for the launcher is unsupported on non-ChromeOS platforms.
+// TODO(amistry): Make speech input, and hotwording, work on non-ChromeOS.
+#if defined(OS_CHROMEOS)
if (HotwordService::IsExperimentalHotwordingEnabled()) {
auto prefs = profile_->GetPrefs();
return HotwordServiceFactory::IsServiceAvailable(profile_) &&
(prefs->GetBoolean(prefs::kHotwordSearchEnabled) ||
prefs->GetBoolean(prefs::kHotwordAlwaysOnSearchEnabled));
}
-#if defined(OS_CHROMEOS)
return HotwordServiceFactory::IsServiceAvailable(profile_) &&
profile_->GetPrefs()->GetBoolean(prefs::kHotwordSearchEnabled);
#else
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698