Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 721093002: Disable new hotwording in the launcher for non-ChromeOS. (Closed)

Created:
6 years, 1 month ago by Anand Mistry (off Chromium)
Modified:
6 years, 1 month ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable new hotwording in the launcher for non-ChromeOS. Voice input in general is unsupported in the launcher for non-ChromeOS. BUG=397019 Committed: https://crrev.com/09bbabf772767b80e77b750f4cbb38e4fe6a18cc Cr-Commit-Position: refs/heads/master@{#304003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/app_list/start_page_service.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Anand Mistry (off Chromium)
6 years, 1 month ago (2014-11-13 06:15:23 UTC) #2
Matt Giuca
lgtm
6 years, 1 month ago (2014-11-13 07:05:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721093002/1
6 years, 1 month ago (2014-11-13 07:08:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-13 07:52:43 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 07:53:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09bbabf772767b80e77b750f4cbb38e4fe6a18cc
Cr-Commit-Position: refs/heads/master@{#304003}

Powered by Google App Engine
This is Rietveld 408576698