Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 721053002: Use "unsigned" rather than "unsigned long" for C++ code interacting with WebIDL's "unsigned long". (Closed)

Created:
6 years, 1 month ago by eroman
Modified:
6 years, 1 month ago
Reviewers:
philipj_slow
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Project:
blink
Visibility:
Public.

Description

Use "unsigned" rather than "unsigned long" for C++ code interacting with WebIDL's "unsigned long". (WebIDL's "unsigned long" is a 32-bit type) BUG=267360 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/modules/mediasource/SourceBufferList.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
eroman
6 years, 1 month ago (2014-11-13 01:27:36 UTC) #2
philipj_slow
lgtm
6 years, 1 month ago (2014-11-13 10:13:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/721053002/1
6 years, 1 month ago (2014-11-13 10:14:12 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 12:08:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185283

Powered by Google App Engine
This is Rietveld 408576698