Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: Source/core/frame/WindowTimers.idl

Issue 721033004: Implement WindowTimers.set{Timeout,Interval} without [Custom] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-overload-with-variadic
Patch Set: rebased Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/DOMWindowTimers.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/WindowTimers.idl
diff --git a/Source/core/frame/WindowTimers.idl b/Source/core/frame/WindowTimers.idl
index 47f394fc249175fc435305994fd8e972a4f1f1ca..c6a72b6d91050c724cd52358d7d7bf5b52a6470e 100644
--- a/Source/core/frame/WindowTimers.idl
+++ b/Source/core/frame/WindowTimers.idl
@@ -32,14 +32,13 @@
LegacyTreatAsPartialInterface,
NoInterfaceObject, // Always used on target of 'implements'
] interface WindowTimers {
- // FIXME: currently using [Custom] and |any| because overload algorithm
- // can't handle Function/DOMString overload properly
- // http://crbug.com/293561
// FIXME: would be clearer as a union type, like:
// typedef (Function or DOMString) Handler
// Needs spec update and better union support: http://crbug.com/240176
- [Custom] long setTimeout(any handler, [Default=Undefined] optional long timeout);
- void clearTimeout([Default=Undefined] optional long handle);
- [Custom] long setInterval(any handler, [Default=Undefined] optional long timeout);
- void clearInterval([Default=Undefined] optional long handle);
+ [CallWith=ScriptState] long setTimeout(Function handler, optional long timeout = 0, any... arguments);
+ [CallWith=ScriptState] long setTimeout(DOMString handler, optional long timeout = 0, any... arguments);
+ void clearTimeout(optional long handle = 0);
+ [CallWith=ScriptState] long setInterval(Function handler, optional long timeout = 0, any... arguments);
+ [CallWith=ScriptState] long setInterval(DOMString handler, optional long timeout = 0, any... arguments);
+ void clearInterval(optional long handle = 0);
};
« no previous file with comments | « Source/core/frame/DOMWindowTimers.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698