Source/bindings/core/v8/ScheduledAction.h - Issue 721033004: Implement WindowTimers.set{Timeout,Interval} without [Custom]

Side by Side Diff: Source/bindings/core/v8/ScheduledAction.h

Issue 721033004: Implement WindowTimers.set{Timeout,Interval} without [Custom] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-overload-with-variadic

Patch Set: rebased Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2007-2009 Google Inc. All rights reserved.	2 * Copyright (C) 2007-2009 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 29 matching lines...) Expand all Loading...
40	40

41 namespace blink {	41 namespace blink {

42	42

43 class LocalFrame;	43 class LocalFrame;

44 class ExecutionContext;	44 class ExecutionContext;

45 class WorkerGlobalScope;	45 class WorkerGlobalScope;

46	46

47 class ScheduledAction {	47 class ScheduledAction {

48 WTF_MAKE_NONCOPYABLE(ScheduledAction);	48 WTF_MAKE_NONCOPYABLE(ScheduledAction);

49 public:	49 public:

50 ScheduledAction(ScriptState, v8::Handle<v8::Function>, int argc, v8::Handle <v8::Value> argv[], v8::Isolate);	50 static PassOwnPtr<ScheduledAction> create(ScriptState*, const ScriptValue&, const Vector<ScriptValue>&);
	Yuta Kitamura 2014/11/14 08:24:06 The meaning of the second and third arguments is n The meaning of the second and third arguments is not immediately obvious; you could put parameter names for these. Jens Widell 2014/11/14 10:19:27 Done. Show quoted text On 2014/11/14 08:24:06, Yuta Kitamura wrote: > The meaning of the second and third arguments is not immediately > obvious; you could put parameter names for these. Done.
51 ScheduledAction(ScriptState, const String&, const KURL&, v8::Isolate);	51 static PassOwnPtr<ScheduledAction> create(ScriptState*, const String&);
	Yuta Kitamura 2014/11/14 08:24:06 Ditto for the second argument. Ditto for the second argument. Jens Widell 2014/11/14 10:19:27 Done. Show quoted text On 2014/11/14 08:24:06, Yuta Kitamura wrote: > Ditto for the second argument. Done.
	52

52 ~ScheduledAction();	53 ~ScheduledAction();

53	54

54 void execute(ExecutionContext*);	55 void execute(ExecutionContext*);

55	56

56 private:	57 private:

	58 ScheduledAction(ScriptState*, const ScriptValue&, const Vector<ScriptValue>& );

	59 ScheduledAction(ScriptState*, const String&);
	Yuta Kitamura 2014/11/14 08:24:06 Ditto. Ditto. Jens Widell 2014/11/14 10:19:27 Done. Show quoted text On 2014/11/14 08:24:06, Yuta Kitamura wrote: > Ditto. Done.
	60

57 void execute(LocalFrame*);	61 void execute(LocalFrame*);

58 void execute(WorkerGlobalScope*);	62 void execute(WorkerGlobalScope*);

59 void createLocalHandlesForArgs(Vector<v8::Handle<v8::Value> >* handles);	63 void createLocalHandlesForArgs(Vector<v8::Handle<v8::Value> >* handles);

60	64

61 ScriptStateProtectingContext m_scriptState;	65 ScriptStateProtectingContext m_scriptState;

62 ScopedPersistent<v8::Function> m_function;	66 ScopedPersistent<v8::Function> m_function;

63 V8PersistentValueVector<v8::Value> m_info;	67 V8PersistentValueVector<v8::Value> m_info;

64 ScriptSourceCode m_code;	68 ScriptSourceCode m_code;

65 };	69 };

66	70

67 } // namespace blink	71 } // namespace blink

68	72

69 #endif // ScheduledAction	73 #endif // ScheduledAction

OLD	NEW

« no previous file with comments | « no previous file | Source/bindings/core/v8/ScheduledAction.cpp » ('j') | Source/bindings/core/v8/custom/V8WindowCustom.cpp » ('J')