Implement WindowTimers.set{Timeout,Interval} without [Custom]

Source/bindings/core/v8/ScheduledAction.cpp

 /*
  * Copyright (C) 2007-2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 28 matching lines @@
 #include "core/dom/Document.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/frame/LocalFrame.h"
 #include "core/workers/WorkerGlobalScope.h"
 #include "core/workers/WorkerThread.h"
 #include "platform/Logging.h"
 #include "platform/TraceEvent.h"
 
 namespace blink {
 
-ScheduledAction::ScheduledAction(ScriptState* scriptState, v8::Handle<v8::Function> function, int argc, v8::Handle<v8::Value> argv[], v8::Isolate* isolate)
+ScheduledAction::ScheduledAction(ScriptState* scriptState, const ScriptValue& function, const Vector<ScriptValue>& arguments, v8::Isolate* isolate)

[haraken, 2014/11/13 12:59:31]

You can drop the v8::Isolate* parameter, since you can retrieve it from
ScriptState.

[Jens Widell, 2014/11/13 13:26:48]

Done.

     : m_scriptState(scriptState)
-    , m_function(isolate, function)
     , m_info(isolate)
     , m_code(String(), KURL(), TextPosition::belowRangePosition())
 {
-    m_info.ReserveCapacity(argc);
-    for (int i = 0; i < argc; ++i)
-        m_info.Append(argv[i]);
+    ASSERT(function.isFunction());
+    m_function.set(isolate, v8::Handle<v8::Function>::Cast(function.v8Value()));
+    m_info.ReserveCapacity(arguments.size());
+    for (const ScriptValue& argument : arguments)
+        m_info.Append(argument.v8Value());
 }
 
 ScheduledAction::ScheduledAction(ScriptState* scriptState, const String& code, const KURL& url, v8::Isolate* isolate)
     : m_scriptState(scriptState)
     , m_info(isolate)
     , m_code(code, url)
 {
 }
 
 ScheduledAction::~ScheduledAction()
@@ skipping 56 matching lines @@
 }
 
 void ScheduledAction::createLocalHandlesForArgs(Vector<v8::Handle<v8::Value> >* handles)
 {
     handles->reserveCapacity(m_info.Size());
     for (size_t i = 0; i < m_info.Size(); ++i)
         handles->append(m_info.Get(i));
 }
 
 } // namespace blink