Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 720983002: Remove implicit conversions from scoped_refptr to T* in media/ (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in media/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Windows build. BUG=110610 TBR=dalecurtis@chromium.org Committed: https://crrev.com/6a37ed84687435709790acb73f20bbf3f862ae3d Cr-Commit-Position: refs/heads/master@{#304111}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -211 lines) Patch
M media/audio/win/audio_device_listener_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/audio/win/audio_low_latency_input_win.cc View 5 chunks +9 lines, -6 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 7 chunks +16 lines, -16 lines 0 comments Download
M media/audio/win/core_audio_util_win.cc View 15 chunks +30 lines, -29 lines 0 comments Download
M media/audio/win/core_audio_util_win_unittest.cc View 21 chunks +71 lines, -70 lines 0 comments Download
M media/video/capture/win/filter_base_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/video/capture/win/pin_base_win.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M media/video/capture/win/video_capture_device_factory_win.cc View 6 chunks +10 lines, -11 lines 0 comments Download
M media/video/capture/win/video_capture_device_mf_win.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M media/video/capture/win/video_capture_device_win.cc View 14 chunks +65 lines, -59 lines 3 comments Download

Messages

Total messages: 29 (13 generated)
dcheng
Sorry, this one was a bit larger than the others... This is hopefully the last ...
6 years, 1 month ago (2014-11-12 23:18:07 UTC) #2
ddorwin
Dan, please use your new OWNERS power. :)
6 years, 1 month ago (2014-11-13 02:05:48 UTC) #5
sandersd (OOO until July 31)
Just nits that are not very relevant to you with this kind of mass change ...
6 years, 1 month ago (2014-11-13 02:25:18 UTC) #8
dcheng
https://codereview.chromium.org/720983002/diff/1/media/video/capture/win/video_capture_device_win.cc File media/video/capture/win/video_capture_device_win.cc (right): https://codereview.chromium.org/720983002/diff/1/media/video/capture/win/video_capture_device_win.cc#newcode126 media/video/capture/win/video_capture_device_win.cc:126: if (pin_enum.get() == NULL) On 2014/11/13 02:25:18, sandersd wrote: ...
6 years, 1 month ago (2014-11-13 02:30:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720983002/1
6 years, 1 month ago (2014-11-13 02:31:25 UTC) #11
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-13 02:31:27 UTC) #13
sandersd (OOO until July 31)
On 2014/11/13 02:31:27, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 1 month ago (2014-11-13 02:34:07 UTC) #14
sandersd (OOO until July 31)
On 2014/11/13 02:34:07, sandersd wrote: > On 2014/11/13 02:31:27, I haz the power (commit-bot) wrote: ...
6 years, 1 month ago (2014-11-13 02:35:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720983002/1
6 years, 1 month ago (2014-11-13 18:44:33 UTC) #17
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-13 18:44:41 UTC) #19
dcheng
Trying one last time before TBRing dalecurtis...
6 years, 1 month ago (2014-11-13 21:58:36 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720983002/1
6 years, 1 month ago (2014-11-13 21:59:45 UTC) #22
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-13 21:59:49 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720983002/1
6 years, 1 month ago (2014-11-13 22:01:33 UTC) #27
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-13 23:29:50 UTC) #28
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 23:36:16 UTC) #29
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a37ed84687435709790acb73f20bbf3f862ae3d
Cr-Commit-Position: refs/heads/master@{#304111}

Powered by Google App Engine
This is Rietveld 408576698