Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Issue 720963002: Fix appcache/fallback test race exposed by the Blink Scheduler. (Closed)

Created:
6 years, 1 month ago by rmcilroy
Modified:
6 years, 1 month ago
Reviewers:
Nate Chapin
CC:
blink-reviews, Sami
Project:
blink
Visibility:
Public.

Description

Fix appcache/fallback test race exposed by the Blink Scheduler. The blink scheduler exposed a race where the onnoupdate event could happen before the iframe has been loaded, causing the test to become flaky. This fix replaces the use of onnoupdate with an onload event on the iframe. Also remove linux specific expectation since the linux expected result is now the same as all other platforms. BUG=432129 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185279

Patch Set 1 #

Patch Set 2 : Check onupdate get's called. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M LayoutTests/http/tests/appcache/fallback.html View 1 1 chunk +7 lines, -0 lines 0 comments Download
D LayoutTests/platform/linux/http/tests/appcache/fallback-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rmcilroy
Nate: could you please take a look, thanks. I'm not sure if it is important ...
6 years, 1 month ago (2014-11-12 23:19:47 UTC) #2
Nate Chapin
lgtm
6 years, 1 month ago (2014-11-13 00:10:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/720963002/40001
6 years, 1 month ago (2014-11-13 08:18:58 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 09:37:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as 185279

Powered by Google App Engine
This is Rietveld 408576698