Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(52)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: sky/tests/modules/script-import.sky
Issue
720903002
:
Script-based imports should basically work (Closed)
Base URL: git@github.com:domokit/mojo.git@master
Patch Set:
Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
sky/engine/core/app/AbstractModule.h
sky/engine/core/app/AbstractModule.cpp
sky/engine/core/app/AbstractModule.idl
sky/engine/core/app/Application.h
sky/engine/core/app/Application.cpp
sky/engine/core/app/Module.h
sky/engine/core/app/Module.cpp
sky/engine/core/app/ModuleLoader.h
sky/engine/core/app/ModuleLoader.cpp
sky/engine/core/core.gni
sky/engine/core/dom/DocumentParser.h
sky/engine/core/html/imports/HTMLImportLoader.cpp
sky/engine/core/html/parser/HTMLDocumentParser.h
sky/engine/core/html/parser/HTMLDocumentParser.cpp
sky/engine/core/loader/MojoLoader.cpp
sky/engine/wtf/HashMap.h
sky/tests/modules/script-import.sky
sky/tests/modules/script-import-expected.txt
View unified diff
|
Download patch
« sky/engine/core/app/ModuleLoader.cpp
('K') |
« sky/engine/wtf/HashMap.h
('k') |
sky/tests/modules/script-import-expected.txt »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<script>
2
module.import("resources/pass.sky").then(function(hello) {
3
internals.notifyTestComplete(hello);
4
});
5
</script>
OLD
NEW
« sky/engine/core/app/ModuleLoader.cpp
('K') |
« sky/engine/wtf/HashMap.h
('k') |
sky/tests/modules/script-import-expected.txt »
('j') |
no next file with comments »
Issue 720903002: Script-based imports should basically work (Closed)
Created 6 years, 1 month ago by abarth-chromium
Modified 6 years, 1 month ago
Reviewers: eseidel
Base URL: git@github.com:domokit/mojo.git@master
Comments: 2
This is Rietveld
408576698
Chromium Code Reviews
Issue 720903002:
Script-based imports should basically work (Closed)
Base URL: git@github.com:domokit/mojo.git@master