Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 720903002: Script-based imports should basically work (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Script-based imports should basically work This CL adds the beginning of a new module loading system that matches the conceptual module in the spec. I've writed it up to the import API on AbstractModule. In a future CL, I'll replace the old module loading system with this one. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/46678b018f9c382f17e02499f0e368987df9d431

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use String::format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -12 lines) Patch
M sky/engine/core/app/AbstractModule.h View 2 chunks +13 lines, -1 line 0 comments Download
M sky/engine/core/app/AbstractModule.cpp View 2 chunks +20 lines, -0 lines 0 comments Download
M sky/engine/core/app/AbstractModule.idl View 1 chunk +3 lines, -1 line 0 comments Download
M sky/engine/core/app/Application.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/core/app/Application.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M sky/engine/core/app/Module.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/core/app/Module.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
A sky/engine/core/app/ModuleLoader.h View 1 chunk +57 lines, -0 lines 0 comments Download
A sky/engine/core/app/ModuleLoader.cpp View 1 1 chunk +66 lines, -0 lines 0 comments Download
M sky/engine/core/core.gni View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/core/dom/DocumentParser.h View 2 chunks +3 lines, -1 line 0 comments Download
M sky/engine/core/html/imports/HTMLImportLoader.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M sky/engine/core/html/parser/HTMLDocumentParser.h View 3 chunks +5 lines, -1 line 0 comments Download
M sky/engine/core/html/parser/HTMLDocumentParser.cpp View 2 chunks +10 lines, -1 line 0 comments Download
M sky/engine/core/loader/MojoLoader.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M sky/engine/wtf/HashMap.h View 5 chunks +7 lines, -6 lines 0 comments Download
A sky/tests/modules/script-import.sky View 1 chunk +5 lines, -0 lines 0 comments Download
A + sky/tests/modules/script-import-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-11-12 19:05:39 UTC) #1
eseidel
lgtm https://codereview.chromium.org/720903002/diff/1/sky/engine/core/app/ModuleLoader.cpp File sky/engine/core/app/ModuleLoader.cpp (right): https://codereview.chromium.org/720903002/diff/1/sky/engine/core/app/ModuleLoader.cpp#newcode36 sky/engine/core/app/ModuleLoader.cpp:36: String message = I think there is a ...
6 years, 1 month ago (2014-11-12 19:23:18 UTC) #2
abarth-chromium
https://codereview.chromium.org/720903002/diff/1/sky/engine/core/app/ModuleLoader.cpp File sky/engine/core/app/ModuleLoader.cpp (right): https://codereview.chromium.org/720903002/diff/1/sky/engine/core/app/ModuleLoader.cpp#newcode36 sky/engine/core/app/ModuleLoader.cpp:36: String message = On 2014/11/12 at 19:23:18, eseidel wrote: ...
6 years, 1 month ago (2014-11-12 21:15:53 UTC) #3
abarth-chromium
6 years, 1 month ago (2014-11-12 21:29:18 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
46678b018f9c382f17e02499f0e368987df9d431 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698