Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 7209001: Crypto: Add crypto_api to code needed outside of crypto (Closed)

Created:
9 years, 6 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
Reviewers:
wtc
CC:
chromium-reviews
Visibility:
Public.

Description

Crypto: Add crypto_api to code needed outside of crypto that is not covered by crypto_unittests BUG=85776 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89756

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M crypto/capi_util.h View 2 chunks +7 lines, -5 lines 0 comments Download
M crypto/nss_util.h View 2 chunks +3 lines, -2 lines 0 comments Download
M crypto/nss_util_internal.h View 2 chunks +3 lines, -1 line 2 comments Download

Messages

Total messages: 3 (0 generated)
rvargas (doing something else)
9 years, 6 months ago (2011-06-18 00:54:34 UTC) #1
wtc
LGTM. http://codereview.chromium.org/7209001/diff/1/crypto/nss_util_internal.h File crypto/nss_util_internal.h (right): http://codereview.chromium.org/7209001/diff/1/crypto/nss_util_internal.h#newcode21 crypto/nss_util_internal.h:21: PK11SlotInfo* GetPublicNSSKeySlot(); We may want to add CRYPTOAPI ...
9 years, 6 months ago (2011-06-20 22:35:40 UTC) #2
rvargas (doing something else)
9 years, 6 months ago (2011-06-20 23:00:37 UTC) #3
Thanks

http://codereview.chromium.org/7209001/diff/1/crypto/nss_util_internal.h
File crypto/nss_util_internal.h (right):

http://codereview.chromium.org/7209001/diff/1/crypto/nss_util_internal.h#newc...
crypto/nss_util_internal.h:21: PK11SlotInfo* GetPublicNSSKeySlot();
On 2011/06/20 22:35:40, wtc wrote:
> We may want to add CRYPTOAPI to this function for symmetry.

Done.

Powered by Google App Engine
This is Rietveld 408576698